Repository navigation
Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation - #2771
Merged
Conversation
… because go_to_bug doesn't wait for the module expand animation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The timeout loop can falsely fail when animation completes during its final sleep interval.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds animation synchronization to go_to_bug to prevent premature Selenium field reads.
Changes:
- Polls jQuery animation state after expanding bug panels.
- Reports a diagnostic failure after a five-second timeout.
| File | Description |
|---|---|
qa/t/lib/QA/Util.pm |
Waits for panel expansion before continuing Selenium tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…rt a false timeout' Co-authored-by: Copilot Autofix powered by AI <[email protected]>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The helper correctly centralizes existing expansion behavior and waits for the relevant jQuery animations without introducing unresolved issues.
Review effort: Balanced
Findings: None
Resolved since last review (1)
Collaborator
Author
|
r+ carried over from #2769 which had to be reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.