Skip to content

rename xarray export's period dims - #543

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:xarray-kper-row
Nov 5, 2026
Merged

wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:xarray-kper-row

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Nov 5, 2026 •

Copy link
Copy Markdown
Member
  • per -> kper
  • layer-array based packages <name>_period -> <name>_kper

The dim per is now kper, including the coordinate on a period list's sparse
entry dim, and a period array's <name>_period is now <name>_kper. The labels
are kper values, 0-based.

Names only: to_xarray's return types, its dense default and sparse=True
don't change. An export written under the old dims doesn't load back.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wpbonelli wpbonelli added this to the MMP milestone Nov 5, 2026
@wpbonelli
wpbonelli marked this pull request as ready for review November 5, 2026 19:26
@wpbonelli
wpbonelli merged commit 0973a77 into modflowpy:develop Nov 5, 2026
18 checks passed
@wpbonelli
wpbonelli deleted the xarray-kper-row branch November 5, 2026 19:41
wpbonelli added a commit to wpbonelli/pyphoenix-project that referenced this pull request Nov 6, 2026
period_data, WorkspaceComponent, kper and <name>_kper in the live plans,
keeping the old names only where they're flopy3's or a record of a decision.
A period list's sparse dim stays entry, with the reasons in representation.md,
and the name for other lists' dims is open. The audit's renames are done.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant