Repository navigation
rename period_data back to stress_period_data - #546
Merged
Merged
Conversation
A stress period is MODFLOW's unit of time, not a property of stress packages, so STO's and OC's per-period settings are stress period data too. The name also matches MF6's term and flopy3's keyword, and the DFNs, which keep it, so codegen no longer maps it. This undoes modflowpy#540's rename, field and class names alike. External list files are <model>_<pkg>_stress_period_data_p<n>.<ext> again, and generated code, grammars and snapshots match those from before modflowpy#540. stress_period_data is no longer a legacy alias, since it's the field. flopy3's other names (perioddata, lakeperioddata, ...) stay aliases as modflowpy#541 made them, and STO's and OC's attribute errors now point to stress_period_data. The kper dims from modflowpy#543 are unaffected. Co-Authored-By: Claude Opus 5.5 <[email protected]>
wpbonelli
added a commit
to wpbonelli/pyphoenix-project
that referenced
this pull request
Nov 6, 2026
… develop STO's value in these 37 is one word per period again. Against this branch before the rebase, they differ only by modflowpy#546's names. Co-Authored-By: Claude Opus 5.5 <[email protected]>
wpbonelli
added a commit
to wpbonelli/pyphoenix-project
that referenced
this pull request
Nov 6, 2026
Record D5's reversal in the audit, and use the name throughout the plans. With the field and flopy3's name the same on most stress packages, the period-list values plan loses its argument for a legacy-only subclass. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undo #540's rename, a stress period is MODFLOW's unit of time, not a concept specific to stress packages