Repository navigation
rename Context to WorkspaceComponent - #542
Merged
Merged
Conversation
A workspace is what the class adds to Component. It moves to component.py, since there's no context left in flopy4/mf6/context.py, which is gone. RowContext, LoadContext, WriteContext and the like are unrelated. simulation.py is from codegen. Co-Authored-By: Claude Opus 5.5 <[email protected]>
wpbonelli
marked this pull request as ready for review
November 5, 2026 19:12
wpbonelli
added a commit
to wpbonelli/pyphoenix-project
that referenced
this pull request
Nov 6, 2026
Also record the rebase over modflowpy#542. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Contextclass was badly named, it means "a component with a workspace (i.e. folder)", so name itWorkspaceComponentand move it tocomponent.py. Makes it clearer thatRowContext,LoadContext,WriteContextetc are unrelated. Context is everything!