Skip to content

support flopy3's period-data attribute names - #541

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:legacy-attrs
Nov 5, 2026
Merged

wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:legacy-attrs

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

the legacy aliases only worked for init, so assigning e.g. wel.stress_period_data silently did nothing and reading it raised. Support attribute access/assignment too, with the same warning as init

A Legacy keyword was only taken by constructors, so assigning
wel.stress_period_data silently did nothing and reading it raised. Each one
is now an attribute too, with the same warning, reading and assigning
period_data. By name only: the value is flopy4's, not an MFTransientList.

STO's and OC's keywords are converted, so they have no value of their own.
Their attributes raise, pointing at period_data.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wpbonelli wpbonelli added this to the MMP milestone Nov 5, 2026
@wpbonelli
wpbonelli marked this pull request as ready for review November 5, 2026 19:12
@wpbonelli
wpbonelli merged commit 927fd8a into modflowpy:develop Nov 5, 2026
18 checks passed
@wpbonelli
wpbonelli deleted the legacy-attrs branch November 5, 2026 19:13
wpbonelli added a commit to wpbonelli/pyphoenix-project that referenced this pull request Nov 6, 2026
Not started. get_data, set_data, .array and .data on PeriodRows, if unchanged
3.x scripts become a goal, since modflowpy#541 only covers the names.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant