Skip to content

test(workflow-tengo): wait for the import error itself in the failed-import effect test - #2008

Merged
vgpopov merged 2 commits into
mainfrom
vp/effect-test-wait-for-import-error
Nov 16, 2026
Merged

vgpopov merged 2 commits into
mainfrom
vp/effect-test-wait-for-import-error

Conversation

@vgpopov

@vgpopov vgpopov commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

The test a failed import fails the effect read the import entry once the effect map was ready or had an error. The effect map can be ready before the import error gets to the entry; the read then gives the fields ([ 'file', 'progress' ]) and no error, and the test fails. It failed this way on the k8s S3 job of milaboratory/pl#2440 and on the CI of #2004 (run 43436626217).

The test now keeps waiting until the read of the entry throws the import error. If the error never comes, the test fails with a timeout. Includes an empty changeset.

🤖 Generated with Claude Code

…import effect test

The effect map can be ready before the import error gets to the entry. A
read of the entry then gives the fields and no error, and the test fails.
It failed this way on the k8s S3 job of the pl CI and on the CI of this repo.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@greptile-apps

greptile-apps Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a919c7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.99%. Comparing base (0db8cca) to head (a919c7c).
⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
+ Coverage   60.46%   60.99%   +0.52%     
==========================================
  Files         443      444       +1     
  Lines       23639    24135     +496     
  Branches     5537     5692     +155     
==========================================
+ Hits        14294    14720     +426     
- Misses       7706     7741      +35     
- Partials     1639     1674      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ches the effect map

The import error climbs one level at a time: entry, imports map, effect
map. The client takes a field with no error as stable, so one stable read
can end before the error arrives, or with the error below the effect map.
Both happened on the k8s S3 job. Poll a fresh read until its error names
the imports field of the effect map.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@vgpopov
vgpopov added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 6bbecf3 Nov 16, 2026
20 of 21 checks passed
@vgpopov
vgpopov deleted the vp/effect-test-wait-for-import-error branch November 16, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants