Repository navigation
Conversation
A ready EphStdMap was final, so the tree stopped re-reading it. A map is ready once its entries resolve to resources, not once those resources settle. An entry that fails later puts its error on the map after ready, and the tree never saw it. The v2 effect hit this: on the k8s backend the import of a missing library file failed after the effect map was ready, and "a failed import fails the effect" read no error for minutes. The map is now never final. The delta benchmark gets an arm of ephemeral maps that compares the old row with the new one. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
🦋 Changeset detectedLatest commit: d3052ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
EphStdMapafter the map is ready.EphStdMapon every poll. The benchmark below shows the cost.Cause
The client finality table held a ready
EphStdMapfinal, so the tree never fetched it again. Backend "ready" asks only that every input points to a resource with a final status. Work below that resource can still fail. The core then lifts the error up to the map after ready, with no controller. On localfs the index of a missing file fails in milliseconds, before the client reads the map. On k8s it fails later, and the poll of #2008 read "no error" for 3 × 60 s.History: 7c0d4c8 (2024-10-10) made
EphStdMapfinal at ready; before it, nothing in the tree was final. #1874 gave the row the reason "its inputs are final at ready, and no controller fills it afterwards". daa13ed (2026-11-05) made the v2 effect anEphStdMap. Full analysis: https://gist.github.com/vgpopov/6536ec7922802a34644da097c5efd0acChange
StrictFinality:EphStdMapmoves from the "final at ready" group to aneverrow. The project stop rules are generated from the table, so the backend no longer stops a walk at a readyEphStdMap.hasOriginalListeners. The shared reason of the "final at ready" rows now says that such a type does not show a late error.StdMap,StdMapSlash,PFrame, and the other rows of that group keep the old rule. They can miss a late error the same way; that stays for a follow-up.Tests
Benchmark
PL_TREE_BENCH=1 pnpm exec vitest run src/delta_benchmark.test.tsinlib/node/pl-tree, local backend 5.0.2, two runs with the same numbers. A new arm seeds 12EphStdMaps × 6 json values and runs every algorithm with the old row and with the new one. Resources fetched over a cold load and 3 polls:The extra 36 fetches are 12 maps × 3 polls. A map carries no data, so the bytes grow by 144. The struct arm matches
mainexactly, and every arm sees all 3 changes. The cost in a real project depends on how manyEphStdMaps its tree holds; I did not measure a real project.🤖 Generated with Claude Code