chore: promote develop to main - #127
Merged
Merged
Conversation
…Shell.psm1 Every feature PR adds its new functions' names to PiHoleShell.psm1's Export-ModuleMember list, which previously always forced the full Pester suite to run on a PR build - the one file nearly every PR touches was exactly the one that defeated the changed-file scoping added in an earlier PR. A pure addition to the export list can't break any existing, already-passing test, so only fall back to the full suite when an existing export was actually removed. Comparing whole diff lines doesn't work here since several exports share one line - adding a new function to an existing category's line shows as that whole line being removed and re-added, even though nothing already there was dropped. Instead, this extracts the quoted names from just the removed lines and just the added lines and compares those sets: a name that reappears in the added lines was only reformatted, not actually removed. Verified against real PR diffs from this session (via git worktree, without touching the live pipeline): a pure-addition change (adding Config's new functions to the Config category's existing line) correctly skips the fallback, and a synthetic removal correctly still triggers it. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This test file's Update-PiHoleClient tests were failing intermittently in CI (3 times in a row across recent builds) with either a 400 on the Update-PiHoleClient call itself or a cascading "already exists" on the next test's New-PiHoleClient call. Every It block calls New-PiHoleClient immediately followed by Update-PiHoleClient with zero delay between them - the real Pi Zero W test server needs a moment to make a just-created client queryable/updatable again, the same known hardware limitation already worked around in tools/Update-ExampleOutput.ps1 for Lists/Domains/Groups, but this test file never got the same fix. Verified with a clean 7/7 pass against the real server after adding a short Start-Sleep between each New-PiHoleClient and the Update-PiHoleClient call that depends on it. Co-Authored-By: Claude Sonnet 5 <[email protected]>
ci: don't run the full test suite for pure export additions to PiHoleShell.psm1
test: fix flaky Update-PiHoleClient tests missing a create-settle delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PiHoleShell.psm1, so most feature PRs get fast, correctly-scoped test runs) intomain.Update-PiHoleClientintegration tests that were missing a create-settle delay for the real test server) intomain.Both are CI/test-infrastructure changes only - no module code changes.
Test plan
develop.🤖 Generated with Claude Code