Skip to content

fix: recognize progress pseudo-elements #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryqdineen merged 3 commits into from
Oct 30, 2026
Merged

fix: recognize progress pseudo-elements #1968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd20ba5
fix: recognize progress pseudo-elements
Arnav7x Oct 20, 2026
2fa66f8
Merge branch 'main' into fix/progress-pseudo-elements
Arnav7x Oct 21, 2026
fc09c3e
Merge branch 'main' into fix/progress-pseudo-elements
Arnav7x Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,23 @@ eslintTester.run('stylex-valid-styles', rule.default, {
},
},
})`,

// test for progress elements
`import * as stylex from '@stylexjs/stylex';
stylex.create({
default: {
'::-webkit-progress-bar': {
appearance: 'none',
},
'::-webkit-progress-value': {
appearance: 'none',
},
'::-moz-progress-bar': {
appearance: 'none',
},
},
})`,

// test for color
`import * as stylex from '@stylexjs/stylex';
stylex.create({
Expand Down
4 changes: 4 additions & 0 deletions packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2380,6 +2380,10 @@ export const pseudoElements: RuleCheck = makeUnionRule(
makeLiteralRule('::-moz-range-thumb'),
makeLiteralRule('::-moz-range-track'),
makeLiteralRule('::-moz-range-progress'),
// For progress elements
makeLiteralRule('::-webkit-progress-bar'),
makeLiteralRule('::-webkit-progress-value'),
makeLiteralRule('::-moz-progress-bar'),
);

export const pseudoClassesAndAtRules: RuleCheck = makeUnionRule(
Expand Down
4 changes: 4 additions & 0 deletions packages/@stylexjs/stylex/src/types/StyleXTypes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ type CSSPropertiesWithExtras = Partial<
'::-moz-range-thumb'?: CSSProperties;
'::-moz-range-track'?: CSSProperties;
'::-moz-range-progress'?: CSSProperties;
// For progress elements
'::-webkit-progress-bar'?: CSSProperties;
'::-webkit-progress-value'?: CSSProperties;
'::-moz-progress-bar'?: CSSProperties;
}
>
>;
Expand Down