Skip to content

fix: recognize progress pseudo-elements - #1968

Merged
henryqdineen merged 3 commits into
meta:mainfrom
Arnav7x:fix/progress-pseudo-elements
Oct 30, 2026
Merged

henryqdineen merged 3 commits into
meta:mainfrom
Arnav7x:fix/progress-pseudo-elements

Conversation

@Arnav7x

@Arnav7x Arnav7x commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

What changed / motivation?

Added support for the following progress pseudo-elements in StyleX's ESLint validation and TypeScript style definitions:

  • ::-webkit-progress-bar
  • ::-webkit-progress-value
  • ::-moz-progress-bar

These are valid CSS pseudo-elements used to style different parts of native progress indicators. Without this support, the ESLint plugin reports them as unknown pseudo-elements, preventing their use in StyleX styles.

Added a regression test covering all three pseudo-elements to ensure they are recognized correctly.

Linked PR/Issues

Fixes #1967

Additional Context

Tests

  • All 9 ESLint plugin test suites passed.
  • All 569 tests passed.
  • git diff --check completed successfully.

Pre-flight checklist

@Arnav7x
Arnav7x requested review from mellyeliu and nmn as code owners October 20, 2026 12:31
@meta-cla

meta-cla Bot commented Oct 20, 2026

Copy link
Copy Markdown

Hi @Arnav7x!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

@Arnav7x is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@henryqdineen

Copy link
Copy Markdown
Collaborator

@Arnav7x are you able to sign the CLA? Thanks!

@Arnav7x

Arnav7x commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

@Arnav7x are you able to sign the CLA? Thanks!

Yep, just did. Works fine for me.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2026
@henryqdineen
henryqdineen merged commit 0f958bb into meta:main Oct 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[eslint-plugin] valid-styles rejects <progress> pseudo-elements (::-webkit-progress-bar, ::-webkit-progress-value, ::-moz-progress-bar)

2 participants