Repository navigation
[STF-1869] Fix release notes and tag handling - #169
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release script rejects empty or whitespace-only release notes and changes how it creates and pushes annotated tags. The release workflow uses a fully qualified tag reference and passes the current ref name to GoReleaser. The GoReleaser configuration no longer disables changelog handling. ChangesRelease Process
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The release workflow carries the curated notes into GoReleaser, and no actionable merge risk is established by the reviewed changes. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the notes for space, Comment |
Related to STF-1869. Companion to mmdbinspect #253.
GoReleaser ignores the supplied notes while
changelog.disableis true. Remove that setting so releases receive the annotated tag body. This also fixes tag formatting and selection errors found while reviewing mmdbinspect #253.Changes
--cleanup=whitespace.Validation
Repository settings
GitHub settings were checked: immutable releases are enforced by the organization, Actions are enabled, and the
releaseenvironment permitsv*tags. The same releaser team approves deployments and can create protected release tags. The workflow grantscontents: writeonly to the release job and uses the built-inGITHUB_TOKEN. No settings changes or additional secrets are needed.Summary by CodeRabbit