Repository navigation
Split build features #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Split build features #244
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f519dd0
build: Add missing dependency declarations
iinuwa c54da5b
build: Move shared dependency declarations to root meson.build
iinuwa 25554ea
build: Make demo-client optional
iinuwa cffc4a2
build: make credentialsd-ui optional
iinuwa 7e21b1c
build: Make webext optional
iinuwa c8ccd1f
build: Make daemon optional
iinuwa fe8712b
build: Missing version bump
iinuwa 15b3626
doc: Update packaging options documentation
iinuwa 4f2a648
build: Rename `default` profile to `release`
iinuwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,4 +46,4 @@ test( | |
| '--nocapture', | ||
| ], | ||
| protocol: 'exitcode', | ||
| ) | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,28 @@ | ||
| dbus_config = configuration_data() | ||
| dbus_service_dir = datadir / 'dbus-1' / 'services' | ||
| dbus_config.set('DAEMON_EXECUTABLE', bindir / backend_executable_name) | ||
| dbus_config.set( | ||
| 'UI_EXECUTABLE', | ||
| bindir / gui_executable_name, | ||
| ) | ||
| configure_file( | ||
| input: 'xyz.iinuwa.credentialsd.Credentials.service.in', | ||
| install_dir: dbus_service_dir, | ||
| output: 'xyz.iinuwa.credentialsd.Credentials.service', | ||
| configuration: dbus_config, | ||
| ) | ||
| configure_file( | ||
| input: 'xyz.iinuwa.credentialsd.UiControl.service.in', | ||
| install_dir: dbus_service_dir, | ||
| output: 'xyz.iinuwa.credentialsd.UiControl.service', | ||
| configuration: dbus_config, | ||
| ) | ||
|
|
||
| if daemon_feat.allowed() | ||
| dbus_daemon_config = configuration_data() | ||
| dbus_daemon_config.set('DAEMON_EXECUTABLE', bindir / backend_executable_name) | ||
|
|
||
| configure_file( | ||
| input: 'xyz.iinuwa.credentialsd.Credentials.service.in', | ||
| install_dir: dbus_service_dir, | ||
| output: 'xyz.iinuwa.credentialsd.Credentials.service', | ||
| configuration: dbus_daemon_config, | ||
| ) | ||
| endif | ||
|
|
||
| if gui_feat.allowed() | ||
| dbus_ui_config = configuration_data() | ||
| dbus_ui_config.set( | ||
| 'UI_EXECUTABLE', | ||
| bindir / gui_executable_name, | ||
| ) | ||
|
|
||
| configure_file( | ||
| input: 'xyz.iinuwa.credentialsd.UiControl.service.in', | ||
| install_dir: dbus_service_dir, | ||
| output: 'xyz.iinuwa.credentialsd.UiControl.service', | ||
| configuration: dbus_ui_config, | ||
| ) | ||
| endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| install_data( | ||
| 'xyz.iinuwa.credentialsd.Credentials.xml', | ||
| install_dir: datadir / 'credentialsd', | ||
| ) | ||
| if daemon_feat.allowed() | ||
| install_data( | ||
| 'xyz.iinuwa.credentialsd.Credentials.xml', | ||
| install_dir: datadir / 'credentialsd', | ||
| ) | ||
| endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reading the docs, I don't think it's clear what exactly "auto" means here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I should explain it more inline. It essentially means it will build if it finds the necessary dependencies, and skip the build if not. Setting to enabled will fail the build on missing dependencies.
But this is a big: I meant to make this enabled by default. Only demo_client should be auto. I'll add a fixup on that.