Repository navigation
Split build features - #244
Conversation
msirringhaus
left a comment
msirringhaus
left a comment
There was a problem hiding this comment.
lgtm. Do we want to add some lines to the docs on how to use it? I assume, for the "build everything"-path, usage stays the same.
|
Finally got around to regenerating the list of options in docs. Took like 3 seconds. Also snuck in a rename of |
msirringhaus
left a comment
msirringhaus
left a comment
There was a problem hiding this comment.
lgtm. Just a stray thought regarding the docs
| cargo_offline false [True, False] Whether to perform an offline build with | ||
| Cargo. Defaults to false to download crates | ||
| from registries. | ||
| feature_daemon auto [enabled, disabled, Whether to build the credentialsd daemon |
There was a problem hiding this comment.
Just reading the docs, I don't think it's clear what exactly "auto" means here.
There was a problem hiding this comment.
yeah, I should explain it more inline. It essentially means it will build if it finds the necessary dependencies, and skip the build if not. Setting to enabled will fail the build on missing dependencies.
But this is a big: I meant to make this enabled by default. Only demo_client should be auto. I'll add a fixup on that.
This splits the build into features to allow building them separately:
Also fixes a missed version bump and dependency declarations (nfc, pcsclite) for credentialsd.