Skip to content

Sweep #1950 (high-risk): changelog drift gate, generic fallback test, genkit doc floor - #1961

Merged
leehack merged 5 commits into
mainfrom
lane-1950-sweep-hr
Nov 12, 2026
Merged

leehack merged 5 commits into
mainfrom
lane-1950-sweep-hr

Conversation

@leehack

@leehack leehack commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Tracks #1950; does not close it. Companion standard-risk PR: #1960

Production-readiness scope

Completeness checklist

  • Declared scope is fully implemented, or explicitly reduced above.
  • Unsupported platform/option combinations fail loudly. (N/A, no runtime change)
  • Docs updated: release-workflow.md describes the new gate; no changelog entry (nothing user-observable).
  • Regression coverage covers the original issue plus negative paths.
  • Validation coverage registry: N/A, no capability change.
  • Security/privacy review: nothing touched.
  • Follow-ups tracked in 0.19.8 audit follow-ups #1950.

PR type guidance

  • Docs-only PR: N/A, tooling and tests included; no runtime behavior changes. Docs built with ./tool/docs/build_site.sh.

Mutation check

Mutant Test Result
D1 never report drift docs_changelog_drift_test.dart killed
D2 no bridge-article normalization same killed
D3 compare Unreleased same killed
D4 flag a section only one file has same killed (after adding a docs-only case)
D5 ignore the whole bridge line same killed
N4 past-the-end fallback generic to contentOnly thinking_budget_resolution_test.dart killed
T6 stale floor in genkit-package.md genkit_doc_floor_test.dart killed
D1 (audit) stale floor in genkit README same killed

Test Plan

  • dart run tool/prepare_workspace.dart
  • dart format --output=none --set-exit-if-changed .
  • dart analyze
  • dart test -p vm -j 1 --exclude-tags local-only N/A locally: ran test/unit/tooling/ (1744 pass) and the thinking-budget test; full lane in CI
  • dart test -p chrome --exclude-tags local-only N/A, no web paths
  • coverage-lib N/A, Dartdoc-only lib/ change
  • Other: verify_release_docs_versions.dart passes on this tree; ./tool/docs/build_site.sh

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
high-risk tier gate, tests, wording macOS, no model N/A surfaces are tooling/doc-only; no affected model family; independent audit pending

Review Notes

  • Independent review status: PASS (fresh auditor-deep at db4c73a, P2 fixed; delta re-audit at 1d4dd75 PASS, 18/18 mutants killed)
  • CI status / head SHA: green (33 pass, 8 skipped) / 1d4dd75

High-risk regression review

  • Classification: high-risk (backendRuntime, regressionPolicy, releaseAutomation, structuredOutput; all from tests, tooling, comments and a Dartdoc)
  • Implementation task: this lane (Sonnet worker)
  • Independent blocking QA task: fresh auditor-deep delta re-audit, PASS, 0 P1/P2; simulated 0.19.8 release prep (faithful - and * bridge bullets pass; tag, version, order and wording drift fail); P3s in 0.19.8 audit follow-ups #1950
  • Exact head / current base: 1d4dd759dc95c2fd54fb900a758127a66bbdc7fa / ec62e97c (main 3f6ccd3e adds only Pin the lazy-grammar pause and the Seed-OSS call-name constraint in tests #1963 tests; merge-tree clean, merge preview passes); evaluator exit 2
  • Production-branch deletion, bypass, or miswire proof: N/A, no production code changes
  • Affected-family real-model/artifact evidence: N/A, no runtime change
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@leehack
leehack marked this pull request as ready for review November 12, 2026 18:39
@leehack leehack mentioned this pull request Nov 12, 2026
17 of 20 tasks
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1961.

@leehack
leehack merged commit 523ab63 into main Nov 12, 2026
74 of 76 checks passed
@leehack
leehack deleted the lane-1950-sweep-hr branch November 12, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant