Repository navigation
Sweep #1950: grammar-pause wording, lazy-grammar test, drift gate, WebGPU error map - #1965
Merged
Merged
Conversation
…te, WebGPU error map
This was referenced Nov 12, 2026
leehack
marked this pull request as ready for review
November 12, 2026 20:52
Contributor
|
Chat app preview removed for |
This was referenced Nov 12, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracks #1950 (does not close it). Four small audit leftovers before 0.19.8 release prep:
think-bodyorseed-thought) stays applied through a budgeted thought, whether aresponseFormator required tool-call grammar. Every lazy grammar pauses, whatever its root, and so does every other grammar. Fixed in thethinkingBudgetDartdoc, the generation guide, the WebGPULlamaUnsupportedExceptiontext,skills/llamadart-web/SKILL.md,doc/webgpu_bridge.md, the website WebGPU page and the two Keep response-format grammars applied through a budgeted thought on WebGPU (#1954) #1964## Unreleasedbullets (reworded, kept in sync, bridge-assets line format unchanged).docsChangelogDriftProblemsnames the first differing line and says when only whitespace differs; the docs page must use the prescribed bridge wording (-marker, no "the"), for every retained docs section.webGpuBridgeRequestErrormaps the bridge'sCompletionOptions.thinkingBudgetandthinkingBudget.pauseGrammarunsupported errors toLlamaUnsupportedException.Production-readiness scope
LlamaUnsupportedException.thinkingBudgetPauseGrammarstill throwLlamaUnsupportedException.Completeness checklist
PR type guidance
*/"the" on the docs page, and an incomplete WebGPU error allowlist (theCompletionOptions.grammargate excludedthinkingBudget). Regression tests below.Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm -j 1 --exclude-tags local-only: touched VM tests (test/integration/thinking_budget_grammar_test.dartwithTMPDIRisolated and 2 threads,test/unit/tooling/, all pass); full lane left to CIdart test -p chrome --exclude-tags local-only:test/unit/backends/webgpu/(540 pass); full lane left to CIcoverage-libmatrix row: N/A, runtimelib/behavior unchanged apart from an error-mapping branch and message text covered by the Chrome testcheck_platform_boundaries,check_webgpu_bridge_tag.dart --verify-manifest,verify_release_docs_versions.dartplain (pass) and--release-prep(fails only on the expected missing## 0.19.7heading and kept## Unreleased, both changelogs),./tool/docs/build_site.shMutation results
llama_cpp_service.dart*marker check / drop the "the default" checkthinkingBudget.pauseGrammaralternative / drop thethinkingBudgetgate## Unreleasedbullets are exempt from the drift gate, so no test can pin themShard weights (#1964 audit T7/T7b): not changed.
doc/ci_selection.mdmakes a missing entry harmless (a new file counts as the median and stale weights only unbalance shards), 29 test files already lack an entry, and the two new entries are placeholders of 0. An "every file has an entry" rule would contradict that contract and fail today; an "every entry exists" rule would only add friction when tests are deleted.Matrix Evidence
high-risk-exact-head-independent-qa$anchor predates the PR); 0.19.8 release-prep simulation passesrelease-metadata-verificationverify_release_docs_versions.dartplain and--release-prepas above;test/unit/tooling/passstructured-output-adversariallitert-lm-v1-public-direct,litert-lm-v1-public-service,litert-lm-v1-public-speech,litert-lm-json-schema,chat-app-litert-json-schemaReview Notes
b9569fba60a0075b210f8934e6f8aad648fd4b96High-risk regression review
backendRuntime,releaseAutomation:webgpu_errors.dart,webgpu_backend.dartmessage,verify_release_docs_versions.dart)b9569fba/ basec2eb1a82. CI: 32 pass, 9 skipped.b9569fba60a0075b210f8934e6f8aad648fd4b96/c2eb1a822d