Skip to content

Sweep #1950: no-apt matcher, hook rebuild-0, genkit tests and docs - #1960

Merged
leehack merged 2 commits into
mainfrom
lane-1950-sweep
Nov 12, 2026
Merged

leehack merged 2 commits into
mainfrom
lane-1950-sweep

Conversation

@leehack

@leehack leehack commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Summary

Tracks #1950; does not close it.

Production-readiness scope

Completeness checklist

  • Declared scope is fully implemented, or explicitly reduced above.
  • Unsupported platform/option combinations fail loudly with actionable diagnostics or are clearly documented as unavailable. (N/A, no runtime change)
  • Public API docs, README/website docs, examples, support matrices, and changelog entries are updated where relevant. (docs updated; no changelog entry, nothing user-observable)
  • Regression coverage covers the original issue plus key negative/version-skew paths where relevant.
  • Public capability changes update the validation coverage registry. (N/A)
  • Security/privacy review completed: no secrets, tokens, signed URLs or secret-bearing paths touched.
  • Follow-up work is tracked in 0.19.8 audit follow-ups #1950.

PR type guidance

  • Docs-only PR: N/A, mixed tests/tooling/docs; no runtime behavior changes. Docs validated with ./tool/docs/build_site.sh.

Mutation check

Mutant Test Result
A1 ignore with: inputs ci_workflow_selection_test.dart system-package check killed
A2 ignore local composite actions same killed
A3 unanchored uses: regex (matches setup-captain) same killed

| M1 bare pin read as another release line | build_hook_litert_lm_integration_test.dart _rebuildOnLine | killed |
| M1b rebuild number ignored | same | killed |
| Date-format check replaced by always-pass, release and publish workflows | test/ci/test_genkit_release.py | killed (2 of 2) |
| M-G grammar: template.grammar -> null | genkit structured JSON test | killed |

Test Plan

  • dart run tool/prepare_workspace.dart
  • dart format --output=none --set-exit-if-changed .
  • dart analyze
  • dart test -p vm -j 1 --exclude-tags local-only N/A locally: ran test/unit/tooling/, the hook test, test/ci unittest and the Markdown suites; full lane in CI
  • dart test -p chrome --exclude-tags local-only N/A, no web paths
  • coverage-lib N/A, no lib/ change
  • Other: ./tool/docs/build_site.sh; genkit test/integration/genkit/actions/model_action (99 pass)

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
N/A tests, tooling, docs macOS N/A standard risk

Review Notes

  • Independent review status: N/A, standard risk
  • CI status / head SHA: see checks

High-risk regression review

  • Classification: standard
  • Implementation task: N/A
  • Independent blocking QA task: N/A
  • Exact head / current base: N/A
  • Production-branch deletion, bypass, or miswire proof: N/A
  • Affected-family real-model/artifact evidence: N/A
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1960.

@leehack
leehack merged commit 083166e into main Nov 12, 2026
101 of 105 checks passed
@leehack
leehack deleted the lane-1950-sweep branch November 12, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant