Skip to content

Pin LiteRT-LM C API 1.0 send-failure text and stack (#1861 sweep 2) - #1888

Closed
leehack wants to merge 1 commit into
fix/1868-v1-send-notefrom
test/1861-sweep-2
Closed

leehack wants to merge 1 commit into
fix/1868-v1-send-notefrom
test/1861-sweep-2

Conversation

@leehack

@leehack leehack commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Summary

Production-readiness scope

  • User-facing scope: None; tests and error plumbing only.
  • Supported platforms/paths: LiteRT-LM C API 1.0 (macOS/Linux VM)
  • Unsupported or intentionally unavailable paths: N/A
  • Out of scope / follow-ups: Refs #1861 (tick after merge); plan #1874.

Test Plan

  • dart format --output=none --set-exit-if-changed and dart analyze on touched dirs
  • TMPDIR=$(mktemp -d) dart test -p vm -j 1 test/unit/backends/litert_lm/litert_lm_v1_conversation_test.dart (45 pass)
  • Full CI: stacked or not on main, run via workflow_dispatch of ci.yml (see comment)

Review Notes

  • Mutants: wrap using toString() fails the text test; dropping throwWithStackTrace fails the new trace assertion (failed first); non-LlamaException at stage 16 fails the restored assertion

High-risk regression review

  • Classification: high-risk (backendRuntime)
  • Implementation task: this PR
  • Independent blocking QA task: pending

@leehack

leehack commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

Landed on main via batch integration PR #1895 (rebase merge, main ba4e0e1b; tree identical to the audited integration head 5ffd1224).

@leehack leehack closed this Nov 10, 2026
@leehack
leehack deleted the test/1861-sweep-2 branch November 10, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant