Skip to content

Pin #1861 audit test gaps; fix Seed-OSS and LiteRT-LM Web doc wording - #1900

Merged
leehack merged 1 commit into
mainfrom
lane-1861a
Nov 10, 2026
Merged

leehack merged 1 commit into
mainfrom
lane-1861a

Conversation

@leehack

@leehack leehack commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Summary

Refs #1861 (tracker not ticked).

Production-readiness scope

  • User-facing scope: docs wording, tests, one example-app message. No lib/ change.
  • Supported platforms/paths: all; the supervisor test is Linux-only.
  • Unsupported or intentionally unavailable paths: N/A
  • Out of scope / follow-ups: the remaining open 0.19.x audit follow-ups (index) #1861 items are listed on the tracker (chunking-dependent MiniMax M3 forced-open stream cases found while pinning E4 go to a separate issue).

Completeness checklist

  • Declared scope is fully implemented.
  • Unsupported platform/option combinations: N/A (no behaviour change).
  • Docs updated; no changelog (no user-visible library change).
  • Regression coverage: see mutation table.
  • Validation coverage registry: N/A (no capability change).
  • Security/privacy review: no secrets or paths touched.
  • Follow-ups tracked on 0.19.x audit follow-ups (index) #1861.

PR type guidance

  • Docs-only PR: N/A (tests and docs).

Test Plan

  • dart format --output=none --set-exit-if-changed .
  • Touched VM suites and test/unit/tooling (see CI)
  • dart test -p chrome test/unit/backends/litert_lm/litert_lm_backend_web_test.dart
  • docker run python:3.12 python -m unittest test.ci.test_supervise_chrome_test (Linux)
  • (cd example/chat_app && flutter test test/unit_test.dart)
  • coverage-lib: N/A, no lib/ change

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
static-format-analyze format macOS PASS
root-vm touched suites macOS VM PASS
root-chrome LiteRT-LM Web backend suite Chrome PASS
examples-tests chat app unit test macOS PASS
docs-site guide/maintainer wording N/A N/A wording only; CI docs lane

Mutation checks (each test fails with the mutant, passes without):

Mutant Result
supervisor done_at = now (pre-#1893) new test_post_done_window_starts_after_a_slow_reporter_poll fails 3/3 on Linux
limit regex without ^ / without $ both new "text before/after" rows fail
merged Web parse id: null new id test fails
merged Web parse content: '' new withheld-content test fails
exactReplyStart without leadingThoughtOnly guard (E4) new chunking test fails
takesThoughtOnlyAtReplyStart: false for minimaxM3 new empty-leading-thought test fails
endsAtFirstEndTag = verbatimThought survives (not pinned; equivalent for the covered shapes)

Review Notes

  • Independent review status: N/A, test and docs only
  • CI status / head SHA: see checks

High-risk regression review

  • Classification: standard
  • Implementation task: N/A
  • Independent blocking QA task: N/A
  • Exact head / current base: N/A
  • Production-branch deletion, bypass, or miswire proof: N/A
  • Affected-family real-model/artifact evidence: N/A
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1900.

@leehack
leehack merged commit 33e00f5 into main Nov 10, 2026
42 checks passed
@leehack
leehack deleted the lane-1861a branch November 10, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant