Skip to content

Pin the native pin changelog over-consumption guards with tests - #1826

Merged
leehack merged 1 commit into
mainfrom
sync-guard-tests
Nov 8, 2026
Merged

leehack merged 1 commit into
mainfrom
sync-guard-tests

Conversation

@leehack

@leehack leehack commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Adds tests pinning the over-consumption guards of update_core_changelog_native_pin: an adjacent - bullet, * bullet and ### heading after a hand-written pin bullet survive; trailing blank lines are consumed but the next paragraph survives.

Refs #1815 (From the #1818 audit; does not close it: the column-0 #1234 continuation under-consumption is left as-is).

Production-readiness scope

Completeness checklist

  • Declared scope fully implemented.
  • Other items N/A: test-only, no production change.

PR type guidance

  • Bugfix PR: N/A, test-only.

Test Plan

  • python3 -m unittest discover -s tool/native -p 'test_*.py' (195 OK); python3 tool/native/test_sync_native_release_pins.py (153 OK); CoreChangelogNativePinTest (6 OK)
  • Mutations, all killed: drop # guard (heading test); drop [-*] guard (dash, star); guard only - (star); drop both (dash, star, heading); drop trailing-blank consumption (trailing-blank test); continuation crossing blanks (trailing-blank test).
  • Dart format/analyze/tests: N/A, no Dart changes.

Matrix Evidence

N/A: only tool/native/test_sync_native_release_pins.py changed; classifier flags it artifactConsumer by path, no production code touched.

Review Notes

  • Independent review status: fresh-agent audit at exact head e64bca8: PASS, zero blocking findings, zero PR-caused P1, 0 unresolved review threads
  • CI status / head SHA: e64bca8; run 42532525239: 32 pass, 9 skipped, 0 fail

High-risk regression review

  • Classification: high-risk (artifactConsumer, path-based; test-only change)
  • Implementation task: this PR
  • Independent blocking QA task: fresh-agent audit, accepted at the exact head (above)
  • Readiness evaluator: tool/testing/high_risk_readiness.dart exit 2 (unverifiedPrerequisites), the expected local result; evidence is v2, base 9f532720b9de18f263e492ef1c049cc1abfd0ae8

@leehack
leehack marked this pull request as ready for review November 8, 2026 23:26
@leehack
leehack merged commit 1131458 into main Nov 8, 2026
43 checks passed
@leehack
leehack deleted the sync-guard-tests branch November 8, 2026 23:26
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1826.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant