Repository navigation
Pin the native pin changelog over-consumption guards with tests - #1826
Merged
Merged
Conversation
Contributor
|
Chat app preview removed for |
This was referenced Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_core_changelog_native_pin: an adjacent-bullet,*bullet and###heading after a hand-written pin bullet survive; trailing blank lines are consumed but the next paragraph survives.Refs #1815 (From the #1818 audit; does not close it: the column-0
#1234continuation under-consumption is left as-is).Production-readiness scope
tool/nativePython tests.#…continuation line stops the match early (pre-existing), tracked in Small follow-ups after 0.19.0 (audit P3s, test gaps, doc nits) #1815.Completeness checklist
PR type guidance
Test Plan
python3 -m unittest discover -s tool/native -p 'test_*.py'(195 OK);python3 tool/native/test_sync_native_release_pins.py(153 OK);CoreChangelogNativePinTest(6 OK)#guard (heading test); drop[-*]guard (dash, star); guard only-(star); drop both (dash, star, heading); drop trailing-blank consumption (trailing-blank test); continuation crossing blanks (trailing-blank test).Matrix Evidence
N/A: only
tool/native/test_sync_native_release_pins.pychanged; classifier flags it artifactConsumer by path, no production code touched.Review Notes
High-risk regression review
tool/testing/high_risk_readiness.dartexit 2 (unverifiedPrerequisites), the expected local result; evidence is v2, base9f532720b9de18f263e492ef1c049cc1abfd0ae8