[jschuurk-kr]

What & why

While testing PR #4190 I discovered that in some situations the modal shown when deleting an investigation does not contain the warning that the related data entry will also be removed. Reason is that we only fetch the data entry states when landing on the investigations overview page. So if a typist starts data entry and the coordinator removes the investigation before returning to the investigations overview page, the coordinator is not informed that removing the investigation will also remove the data entry.

There's also the similar scenario in which a typist deletes their data entry and the coordinator deletes the investigation before the data entry status is refreshed. In that case the coordinator does see the warning when they shouldn't.

I opted to solve this by making the investigations overview page use our useLiveData hook instead of only re-fetching when the component mounts. Three reasons for this:

1. It solves most occurrences of the scenarios above, assuming that coordinators are most likely to trigger the scenario by staying for a while on the investigations overview page and then clicking an investigation to remove it.
2. We show the data entry status on the investigations overview page. So it's odd not to auto-refresh this page like we do with the data entry status page.
3. It's a small change.

How to test

Coordinator - typist:

1. Go to the investigations overview page.
2. Make sure there is an investigation for which data entry has not started yet.
3. In a separate session, as typist start the data entry for the investigation.
4. See the investigation overview page fetch the status data and update the page.

Coordinator - coordinator:

1. Go to the investigations overview page with two coordinators in two browsers.
2. Add an investigation. Edit it etc. with one of the coordinators.
3. Check if the data shown to the other coordinator is updated automatically.

Optionally, also try deleting the investigation at various points and check the modal for the text "Let op: De gecorrigeerde telresultaten die al zijn ingevoerd worden ook verwijderd."

Reviewer notes

I looked at the ElectionStatusPage component and useLiveData function to make sure the only change is that the page now also auto-refreshes. Please check that is indeed the case.

[jschuurk-kr]

Several tests in InvestigationsOverviewPage.test.tsx fail, presumably because of the overrideOnce() on "/api/elections/1" which means a second request due to using live data does not get the mocked response.