Repository navigation
Fix re-adding investigation after deletion - #4190
Merged
Merged
Conversation
Contributor
oliver3
approved these changes
Oct 29, 2026
oliver3
left a comment
Contributor
There was a problem hiding this comment.
No comments that are worth another review cycle
Contributor
|
Tested a variety of scenarios of deleting investigations, data entries and polling stations. Did not find any issues causing incorrect data states. Did discover it's a good idea to fetch data entry status more often on the investigation pages. Created PR #4218 for that. |
jschuurk-kr
approved these changes
Oct 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What & why
When an investigation with corrected results was deleted, its data entry stayed behind. Adding a new investigation for the same polling station and concluding it then gave an internal server error. This is fixed by deleting any linked data entry when an investigation is deleted. Fixes #4172.
How to test
This works with this PR. On
mainit gives an internal server error.Reviewer notes
main), the second commit fixes the issue and makes the tests pass.delete_investigation_for_polling_stationdeletes any linked data entry as well. Both the investigation delete endpoint and the polling station delete endpoint use it.investigation_repo::deletereturns aDataEntryAlreadyLinkederror if the polling station still has a data entry, to prevent this issue from reoccurring in another code path.api/toservice/.