Skip to content

Mac: app version matches its release; installer check on macos-15 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juw12 merged 2 commits into from
Nov 11, 2026
Merged

Mac: app version matches its release; installer check on macos-15 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
218e3dc
CI: Mac installer check on macos-15 and only on main pushes
juwpegatron Nov 11, 2026
395a0c0
Mac app version matches its release (1.3.2) and publish checks it
juwpegatron Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/mac-install-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Mac one-line installer
on:
workflow_dispatch:
push:
branches: [main]
paths:
- "docs/mac-install.sh"
- ".github/workflows/mac-install-check.yml"
Expand All @@ -10,7 +11,7 @@ jobs:
install:
strategy:
matrix:
os: [macos-14, macos-15-intel]
os: [macos-15, macos-15-intel]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,11 @@ jobs:
GH_TOKEN: ${{ github.token }}
run: |
TAG=$(gh release view --repo "$GITHUB_REPOSITORY" --json tagName --jq .tagName)
# The manifest gives the Mac entry the release's version; an app with another version would offer itself
# as an update forever. Refuse to upload unless the app inside the zip has the release's version.
APP_VERSION=$(unzip -p Buddy-mac.zip Buddy.app/Contents/Info.plist | python3 -c "import plistlib,sys; print(plistlib.load(sys.stdin.buffer)['CFBundleShortVersionString'])")
if [ "$APP_VERSION" != "${TAG#v}" ]; then
echo "::error::Buddy.app is $APP_VERSION but the latest release is $TAG; set VERSION in mac/buddy_mac/core.py to ${TAG#v}"
exit 1
fi
gh release upload "$TAG" Buddy-mac.zip --clobber --repo "$GITHUB_REPOSITORY"
2 changes: 1 addition & 1 deletion mac/buddy_mac/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from pathlib import Path

APP_NAME = "Buddy"
VERSION = "1.2.0"
VERSION = "1.3.2"

SUPPORT_DIR = Path.home() / "Library" / "Application Support" / APP_NAME
SETTINGS_PATH = SUPPORT_DIR / "settings.json"
Expand Down
2 changes: 1 addition & 1 deletion mac/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def test_island_is_on_by_default():
assert core.DEFAULTS["island"] is True


# --------------------------------------------------------------------------- languages (1.2.0)
# --------------------------------------------------------------------------- languages (1.3.2)
def test_prompt_answers_in_the_questions_language():
assert "Reply in the language of the question" in core.SYSTEM_PROMPT

Expand Down
Loading