Repository navigation
Mac: app version matches its release; installer check on macos-15 - #21
Merged
Merged
Conversation
macos-14 is no longer offered by GitHub (job cancelled: configuration 'macos-14-arm64-us-default' is not supported), so the Apple Silicon install was never checked. Tag pushes ignore path filters, so every release started this check before Buddy-mac.zip existed and it 404ed.
The manifest gives the Mac entry the version of the release the zip is in (1.3.2), but the app said 1.2.0, so Mac Buddy would offer the same build as an update forever. The publish job now refuses to upload a zip whose Info.plist version differs from the release tag.
juw12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mac one-line installer check never tested Apple Silicon: GitHub no longer offers
macos-14(job cancelled with "The configuration 'macos-14-arm64-us-default' is not supported"), so every run ended cancelled. Switched tomacos-15, the runnermac.ymlalready builds on.Tag pushes ignore path filters, so each release started this check before
Buddy-mac.zipwas attached and the download 404ed (run 43043899108, attempt 1). The push trigger is now limited tomain;workflow_dispatchstill allows a manual post-release check.Mac version (bug in 1.3.2's Mac zip):
tools/release_manifest.pygives the Mac entry the version of the release the zip is in (1.3.2), butmac/buddy_mac/core.pysaid 1.2.0, soupdater.checkwould offer the same build as an update forever. VERSION is now 1.3.2 (as 1.1.0 was in v1.1.0), and themac.ymlpublish job refuses to upload a zip whoseCFBundleShortVersionStringdiffers from the release tag.