Repository navigation
stats: the snapshot reads one snapshot and is exact as of its as_of - #638
Merged
Merged
Conversation
Under read committed a migration could commit between the refresh's ledger read and its recount, so the payload mixed two instants under an as_of later than both (Codex on #636). The refresh now reads in one repeatable read, read only transaction whose instant is the as_of; a migration during it is seen whole by the next refresh. The write never replaces a newer snapshot with an older one. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
jthingelstad
marked this pull request as ready for review
October 21, 2026 07:47
jthingelstad
enabled auto-merge (rebase)
October 21, 2026 07:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Deployed to production 2026-10-21T07:52:47Z (2026-10-21 02:52:47 CDT).
|
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex on #636: under read committed, a migration could commit between the stats refresh's ledger read and its recount. The payload then mixed two instants, under an
as_of(the write time) later than both.repeatable read read onlytransaction (refreshInOneSnapshot), and that transaction's instant is theas_of.as_of. A migration that lands during the refresh is invisible to it, ledger and deletion alike, and the next refresh counts in full.as_ofmust come before the commit, and the next refresh must count in full. The test fails under read committed.No migration, contract or JSON API change. No acceptance family: no tool reads the snapshot.
🤖 Generated with Claude Code