Repository navigation
stats: keep a day of fetch-series marks, so a deploy burst cannot force full counts - #643
Merged
Merged
Conversation
…ce full counts Every refresh adds a mark, platform deploys included. With six kept, six refreshes inside an hour would push out every mark an hour old and the next refresh would count the whole series (about 18,000 blocks, 1.6 s). Five landed between 07:05Z and 08:05Z on 2026-10-21. MARKS_KEPT is now 24; the state row grows by about 1.5 KB. The test runs eight refreshes in a row and fails at the seventh with six kept. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jthingelstad
marked this pull request as ready for review
October 21, 2026 09:15
jthingelstad
enabled auto-merge (rebase)
October 21, 2026 09:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Deployed to production 2026-10-21T09:20:05Z (2026-10-21 04:20:05 CDT).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform review 2026-10-21 §3, measured follow-up to #627, #636 and #638.
Every refresh of the hourly public-stats snapshot adds a fetch-series mark, and so does every platform deploy. With six marks kept, six refreshes inside one hour would push out every mark an hour old. The next refresh would then count the whole series: about 18,000 blocks from disk, 1.6 s. Five refreshes landed between 07:05Z and 08:05Z today.
MARKS_KEPTgoes from 6 to 24. The state row grows by about 1.5 KB.docs/notes/2026-10-21-stats-marks-kept.md. It also explains the two full counts this morning (08:05Z, 09:05Z). Their cause was a new state, not eviction. From 09:08Z,{profile_read}named2026-10-21.The counts stay exact. There is no migration, contract or JSON API change, and no acceptance family is needed.
🤖 Generated with Claude Code