Skip to content

Remove Daft ClickHouse dependency and binding - #111

Merged
jiangxt2 merged 2 commits into
masterfrom
remove-daft-clickhouse-binding
Oct 6, 2026
Merged

jiangxt2 merged 2 commits into
masterfrom
remove-daft-clickhouse-binding

Conversation

@jiangxt2

@jiangxt2 jiangxt2 commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Description

Remove Tributo's built-in Daft ClickHouse Binding and daft-clickhouse from the clickhouse extra and runtime-image contracts. Keep clickhouse-connect and the existing Ray ClickHouse Binding with its external ray-clickhouse==0.1.0 wheel path. Update the lock file, route tests, runtime-image checks, API reference, and support documentation. Make the binding-test metadata mock fall back to real lookups for distributions outside its fixture map so the isolated Ray diagnostic test is order-independent.

Selecting Daft for ClickHouse no longer resolves a built-in route; Ray-based ClickHouse reads remain available.

Related issues

None.

Additional information

  • Tests: uv run --locked --no-sync python scripts/pr-precheck.py passed with two non-blocking warnings; the CI unit suite passed on Python 3.12 and 3.13, and documentation checks passed. The focused Iceberg diagnostic test passed both engine parametrizations.
  • Static checks passed: uv lock --check --offline, python3 tools/generate_public_api_reference.py --check, JSON parsing for tests/integrations/runtime-profiles.json, Ruff lint/import/format checks, and git diff --check.
  • The precheck warnings are the pre-existing inline import at tests/data/test_source_bindings.py:847 and the repository's large uv.lock file.
  • No new runtime dependencies were added; clickhouse-connect remains in the clickhouse extra.
  • Real ClickHouse conformance remains an external validation gate.

@jiangxt2
jiangxt2 merged commit ff0ee58 into master Oct 6, 2026
15 checks passed
@jiangxt2
jiangxt2 deleted the remove-daft-clickhouse-binding branch October 6, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant