Repository navigation
Remove Daft ClickHouse dependency and binding - #111
Merged
Merged
Conversation
Signed-off-by: jiangxt2 <[email protected]>
Signed-off-by: jiangxt2 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove Tributo's built-in Daft ClickHouse Binding and
daft-clickhousefrom theclickhouseextra and runtime-image contracts. Keepclickhouse-connectand the existing Ray ClickHouse Binding with its externalray-clickhouse==0.1.0wheel path. Update the lock file, route tests, runtime-image checks, API reference, and support documentation. Make the binding-test metadata mock fall back to real lookups for distributions outside its fixture map so the isolated Ray diagnostic test is order-independent.Selecting Daft for ClickHouse no longer resolves a built-in route; Ray-based ClickHouse reads remain available.
Related issues
None.
Additional information
uv run --locked --no-sync python scripts/pr-precheck.pypassed with two non-blocking warnings; the CI unit suite passed on Python 3.12 and 3.13, and documentation checks passed. The focused Iceberg diagnostic test passed both engine parametrizations.uv lock --check --offline,python3 tools/generate_public_api_reference.py --check, JSON parsing fortests/integrations/runtime-profiles.json, Ruff lint/import/format checks, andgit diff --check.tests/data/test_source_bindings.py:847and the repository's largeuv.lockfile.clickhouse-connectremains in theclickhouseextra.