Repository navigation
Prepare master for Pista 2.6.0 development - #9
Conversation
Signed-off-by: jiangxt2 <[email protected]>
|
| Reuse successful RC Submitter IT evidence when it exercised the same Assembly JAR | ||
| and the downloaded hashes match. A separate consumer smoke is needed only when | ||
| distribution or entry-point changes leave a concrete runtime coverage gap. |
There was a problem hiding this comment.
The new reuse rule drops two checks that the consumer smoke previously required. PistaFunctionSubmitterIT submits console output without checking its contents, and no submission test checks that a required output failure makes the job fail. BatchSubmitterIT.submit only checks for a successful exit.
Because extra tests are now required only for gaps caused by distribution or entry-point changes, these existing gaps can go unchecked in future releases. Reuse evidence for covered behavior, but retain focused checks for output contents and required-output failures.
| Reuse successful RC Submitter IT evidence when it exercised the same Assembly JAR | |
| and the downloaded hashes match. A separate consumer smoke is needed only when | |
| distribution or entry-point changes leave a concrete runtime coverage gap. | |
| Reuse successful RC Submitter IT evidence for covered behavior when it exercised | |
| the same Assembly JAR and the downloaded hashes match. Run focused consumer smoke | |
| checks for behavior that evidence does not cover, including Spark-native output | |
| contents and required-output failure propagation. Also check any concrete runtime | |
| coverage gaps caused by distribution or entry-point changes. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/releases.md
Line: 69-71
Comment:
**Release checks lose coverage**
The new reuse rule drops two checks that the consumer smoke previously required. `PistaFunctionSubmitterIT` submits console output without checking its contents, and no submission test checks that a required output failure makes the job fail. `BatchSubmitterIT.submit` only checks for a successful exit.
Because extra tests are now required only for gaps caused by distribution or entry-point changes, these existing gaps can go unchecked in future releases. Reuse evidence for covered behavior, but retain focused checks for output contents and required-output failures.
```suggestion
Reuse successful RC Submitter IT evidence for covered behavior when it exercised
the same Assembly JAR and the downloaded hashes match. Run focused consumer smoke
checks for behavior that evidence does not cover, including Spark-native output
contents and required-output failure propagation. Also check any concrete runtime
coverage gaps caused by distribution or entry-point changes.
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Signed-off-by: jiangxt2 <[email protected]>
Pull request
What changes were proposed in this pull request?
Why are the changes needed?
Development builds need a distinct version after the stable release. Documentation must reflect the published distribution and avoid repeating runtime validation for the same verified artifact.
Related issues
None.
Does this PR introduce any user-facing change?
Source builds use 2.6.0-SNAPSHOT. Stable downloads remain at 2.5.0. Runtime baselines, historical introduced-version annotations, configuration and execution behavior remain unchanged.
How was this patch tested?
python3 -B scripts/check_public_content.py,python3 -B scripts/check_language.py,python3 -B scripts/check_markdown.pyandpython3 -B scripts/check_public_license.pypassed.git diff --checkand static review of the complete change passed.The change is limited to release metadata and documentation; no runtime behavior changes.