Repository navigation
fix(chores): a display in another time zone shows the household's chore day - #318
Merged
Merged
Conversation
…re day shouldShowChoreToday read the crontab in the household zone but compared it against midnight in the browser's zone. When the two zones are on different dates, a chore set for chosen weekdays showed on the wrong day: with the household on UTC and a browser in Los Angeles, a Monday-only chore showed all Sunday evening. The chore sounds and the daily bonus gate (hasOutstandingBonusChore) followed the same wrong day, so the widget could disagree with the server's bonus. - shouldShowChoreToday matches the crontab against the household's date (getTodayDateString) with cronFiresOn from choreDays.js, the calendar match the chore history row already uses and the server's cronFiresOnDate mirrors. hasOutstandingBonusChore passes its today. - isVacationModeActiveToday defaults today to the household's date, not the browser's, so vacation starts and ends on the household's day. - Until /api/timezone answers, the client assumes the browser's own zone instead of America/New_York. Every-day chores were never affected. Tests set the browser and the household zones on either side of midnight, both ways.
adamecker
pushed a commit
to adamecker/HomeGlow
that referenced
this pull request
Oct 24, 2026
…e 1.10 jherforth#321, plugin storage/proxy fixes jherforth#319, chore timezone display jherforth#318, CI pins jherforth#316-317, prize descriptions jherforth#315, proxmox/docker fixes jherforth#314, plugin proxy docs jherforth#313, Google OAuth escaping jherforth#312, upload typing/sandbox jherforth#311 Resolve registry conflict: keep fork renumbering (local 28 userGoogleTasks, 34 googleTasksTables); upstream's new 35 proxyWhitelistSeed and 36 prizeDescription renumbered to 41 and 42 to keep schemaIds unique and matching file names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A display whose browser is in another time zone than the household now shows the household's chore day. Details in mrramam#68.
shouldShowChoreTodayread the crontab in the household zone but compared it against midnight in the browser's zone. When the two are on different dates, chores set for chosen weekdays show on the wrong day: with the household on Los Angeles and a browser on Tokyo time on a Friday evening, Friday's chores disappear and Saturday's show. The chore sounds and the bonus gate (hasOutstandingBonusChore) follow the same wrong day, so the widget can disagree with the server's daily bonus. Every-day chores were never affected.shouldShowChoreTodaymatches the crontab against the household's date (getTodayDateString) withcronFiresOnfromchoreDays.js, the calendar match the chore history row already uses and the server'scronFiresOnDatemirrors.hasOutstandingBonusChorepasses itstoday.isVacationModeActiveTodaydefaultstodayto the household's date, so vacation starts and ends on the household's day./api/timezoneanswers, the client assumes the browser's own zone instead ofAmerica/New_York.Tests put the browser and the household on either side of midnight, both ways. Three
timezone.test.jscases now expect the browser-zone fallback.On our hg-dev and production. We checked it with a browser on Tokyo time against a Los Angeles household: the fixed build shows the same chores as a Los Angeles browser, and the old one showed Saturday's.