Repository navigation
fix(antigravity-local): resolve dangerouslySkipPermissions and printTimeout in testEnvironment - #767
Conversation
…imeout in testEnvironment
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
| const printTimeout = resolveAntigravityPrintTimeout({ | ||
| printTimeout: config.printTimeout, | ||
| printTimeoutSec: config.printTimeoutSec, | ||
| timeoutSec: 180, | ||
| extraArgs, | ||
| }); |
There was a problem hiding this comment.
This magic number 180 duplicates the probe's own timeoutSec: 180 passed to runChildProcess below (and the "180s" mentioned in the failure hint). The --print-timeout fallback must semantically track the harness probe timeout, so the three values can silently drift apart if one is changed. Consider extracting a module-level constant (e.g. const SMOKE_PROBE_TIMEOUT_SEC = 180;) and reusing it in both places.
Suggestion:
| const printTimeout = resolveAntigravityPrintTimeout({ | |
| printTimeout: config.printTimeout, | |
| printTimeoutSec: config.printTimeoutSec, | |
| timeoutSec: 180, | |
| extraArgs, | |
| }); | |
| const SMOKE_PROBE_TIMEOUT_SEC = 180; | |
| // ... | |
| const printTimeout = resolveAntigravityPrintTimeout({ | |
| printTimeout: config.printTimeout, | |
| printTimeoutSec: config.printTimeoutSec, | |
| timeoutSec: SMOKE_PROBE_TIMEOUT_SEC, | |
| extraArgs, | |
| }); |
| timeoutSec: 180, | ||
| extraArgs, | ||
| }); | ||
| const bypassPermissions = resolveAntigravityBypassPermissions(config); |
There was a problem hiding this comment.
이번 변경에서 printTimeout/bypassPermissions 해석을 args.ts의 공용 리졸버로 추출했지만, 바로 위의 extraArgs 폴백 로직(extraArgs가 비어 있으면 레거시 args 사용)은 test.ts(93-97행)와 execute.ts(216-220행)에 그대로 중복되어 있습니다. resolveAntigravityPrintTimeout/resolveAntigravityBypassPermissions와 같은 패턴으로 resolveAntigravityExtraArgs(config) 헬퍼를 args.ts에 추출하면 두 호출부(스모크 프로브와 실제 실행)의 인자 해석이 항상 일관되게 유지됩니다. (model/effort 파싱도 동일하게 중복되어 있습니다.)
Suggestion:
| const bypassPermissions = resolveAntigravityBypassPermissions(config); | |
| // args.ts | |
| export function resolveAntigravityExtraArgs(config: Record<string, unknown>): string[] { | |
| const fromExtraArgs = asStringArray(config.extraArgs); | |
| if (fromExtraArgs.length > 0) return fromExtraArgs; | |
| return asStringArray(config.args); | |
| } | |
| // test.ts / execute.ts | |
| const extraArgs = resolveAntigravityExtraArgs(config); |
Summary
resolveAntigravityBypassPermissions(config)insidetestEnvironment(packages/adapters/antigravity-local/src/server/test.ts) so enablingdangerouslySkipPermissionsin the UI passes--dangerously-skip-permissionsduring the hello probe (while preserving legacybypassPermissionsfallback and explicitfalseoverride, matchingexecute.ts).resolveAntigravityPrintTimeout({ printTimeout: config.printTimeout, printTimeoutSec: config.printTimeoutSec, timeoutSec: 180, extraArgs })soprintTimeoutSecandextraArgs--print-timeoutoverrides work cleanly without duplicate flags.packages/adapters/antigravity-local/src/server/test.test.tscoveringdangerouslySkipPermissions, legacybypassPermissions,printTimeoutSec/extraArgs, and failure warning checks.Verification
pnpm --filter @paperclipai/adapter-antigravity-local build(passed)npx vitest run packages/adapters/antigravity-local server/src/__tests__/antigravity-local-adapter-environment.test.ts server/src/__tests__/antigravity-models.test.ts(6 files, 37 tests passed)pnpm -r typecheck(passed, exit 0)node scripts/check-run-status-write-chokepoint.mjs(passed)