Skip to content

fix(antigravity-local): resolve dangerouslySkipPermissions and printTimeout in testEnvironment - #767

Merged
insightflo merged 1 commit into
mainfrom
fix/antigravity-test-env-permissions
Nov 18, 2026
Merged

insightflo merged 1 commit into
mainfrom
fix/antigravity-test-env-permissions

Conversation

@insightflo

Copy link
Copy Markdown
Owner

Summary

  • Use resolveAntigravityBypassPermissions(config) inside testEnvironment (packages/adapters/antigravity-local/src/server/test.ts) so enabling dangerouslySkipPermissions in the UI passes --dangerously-skip-permissions during the hello probe (while preserving legacy bypassPermissions fallback and explicit false override, matching execute.ts).
  • Use resolveAntigravityPrintTimeout({ printTimeout: config.printTimeout, printTimeoutSec: config.printTimeoutSec, timeoutSec: 180, extraArgs }) so printTimeoutSec and extraArgs --print-timeout overrides work cleanly without duplicate flags.
  • Add packages/adapters/antigravity-local/src/server/test.test.ts covering dangerouslySkipPermissions, legacy bypassPermissions, printTimeoutSec/extraArgs, and failure warning checks.

Verification

  • pnpm --filter @paperclipai/adapter-antigravity-local build (passed)
  • npx vitest run packages/adapters/antigravity-local server/src/__tests__/antigravity-local-adapter-environment.test.ts server/src/__tests__/antigravity-models.test.ts (6 files, 37 tests passed)
  • pnpm -r typecheck (passed, exit 0)
  • node scripts/check-run-status-write-chokepoint.mjs (passed)

@insightflo
insightflo merged commit 7af9e03 into main Nov 18, 2026
6 checks passed
@insightflo
insightflo deleted the fix/antigravity-test-env-permissions branch November 18, 2026 06:09
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

🔍 OpenCodeReview found 2 issue(s) in this PR.

  • ✅ Successfully posted inline: 2 comment(s)

Comment on lines +98 to +103
const printTimeout = resolveAntigravityPrintTimeout({
printTimeout: config.printTimeout,
printTimeoutSec: config.printTimeoutSec,
timeoutSec: 180,
extraArgs,
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · low
This magic number 180 duplicates the probe's own timeoutSec: 180 passed to runChildProcess below (and the "180s" mentioned in the failure hint). The --print-timeout fallback must semantically track the harness probe timeout, so the three values can silently drift apart if one is changed. Consider extracting a module-level constant (e.g. const SMOKE_PROBE_TIMEOUT_SEC = 180;) and reusing it in both places.

Suggestion:

Suggested change
const printTimeout = resolveAntigravityPrintTimeout({
printTimeout: config.printTimeout,
printTimeoutSec: config.printTimeoutSec,
timeoutSec: 180,
extraArgs,
});
const SMOKE_PROBE_TIMEOUT_SEC = 180;
// ...
const printTimeout = resolveAntigravityPrintTimeout({
printTimeout: config.printTimeout,
printTimeoutSec: config.printTimeoutSec,
timeoutSec: SMOKE_PROBE_TIMEOUT_SEC,
extraArgs,
});

timeoutSec: 180,
extraArgs,
});
const bypassPermissions = resolveAntigravityBypassPermissions(config);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · low
이번 변경에서 printTimeout/bypassPermissions 해석을 args.ts의 공용 리졸버로 추출했지만, 바로 위의 extraArgs 폴백 로직(extraArgs가 비어 있으면 레거시 args 사용)은 test.ts(93-97행)와 execute.ts(216-220행)에 그대로 중복되어 있습니다. resolveAntigravityPrintTimeout/resolveAntigravityBypassPermissions와 같은 패턴으로 resolveAntigravityExtraArgs(config) 헬퍼를 args.ts에 추출하면 두 호출부(스모크 프로브와 실제 실행)의 인자 해석이 항상 일관되게 유지됩니다. (model/effort 파싱도 동일하게 중복되어 있습니다.)

Suggestion:

Suggested change
const bypassPermissions = resolveAntigravityBypassPermissions(config);
// args.ts
export function resolveAntigravityExtraArgs(config: Record<string, unknown>): string[] {
const fromExtraArgs = asStringArray(config.extraArgs);
if (fromExtraArgs.length > 0) return fromExtraArgs;
return asStringArray(config.args);
}
// test.ts / execute.ts
const extraArgs = resolveAntigravityExtraArgs(config);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant