Repository navigation
refactor(antigravity-local): extract resolveAntigravityExtraArgs helper and probe timeout constant - #770
Merged
Conversation
insightflo
force-pushed
the
refactor/antigravity-local-extra-args-helper
branch
from
November 18, 2026 07:35
ee2d453 to
c2b16af
Compare
…er and probe timeout constant
insightflo
force-pushed
the
refactor/antigravity-local-extra-args-helper
branch
from
November 18, 2026 07:38
c2b16af to
539d980
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses both maintainability suggestions from PR #767's OpenCodeReview feedback:
SMOKE_PROBE_TIMEOUT_SEC = 180inpackages/adapters/antigravity-local/src/server/test.tsand reuse it acrossresolveAntigravityPrintTimeout,runChildProcess, and the failurehint.resolveAntigravityExtraArgs(config)intopackages/adapters/antigravity-local/src/server/args.ts(re-exported byexecute.ts) so bothexecute.tsandtest.tsshare theextraArgs-> legacyargsfallback.packages/adapters/antigravity-local/src/server/test.test.tsforresolveAntigravityExtraArgs, legacyargsfallback duringtestEnvironment, and the probe timeout hint.Verification
pnpm --filter @paperclipai/adapter-antigravity-local build(passed)npx vitest run packages/adapters/antigravity-local server/src/__tests__/antigravity-local-adapter-environment.test.ts server/src/__tests__/antigravity-models.test.ts(6 files, 38 tests passed)pnpm -r typecheck(passed, exit 0)node scripts/check-run-status-write-chokepoint.mjs&bash scripts/check-dockerfile-deps-stage.sh(passed)