Skip to content

refactor(antigravity-local): extract resolveAntigravityExtraArgs helper and probe timeout constant - #770

Merged
insightflo merged 1 commit into
mainfrom
refactor/antigravity-local-extra-args-helper
Nov 18, 2026
Merged

insightflo merged 1 commit into
mainfrom
refactor/antigravity-local-extra-args-helper

Conversation

@insightflo

Copy link
Copy Markdown
Owner

Summary

Addresses both maintainability suggestions from PR #767's OpenCodeReview feedback:

  • Extract SMOKE_PROBE_TIMEOUT_SEC = 180 in packages/adapters/antigravity-local/src/server/test.ts and reuse it across resolveAntigravityPrintTimeout, runChildProcess, and the failure hint.
  • Extract resolveAntigravityExtraArgs(config) into packages/adapters/antigravity-local/src/server/args.ts (re-exported by execute.ts) so both execute.ts and test.ts share the extraArgs -> legacy args fallback.
  • Add unit coverage in packages/adapters/antigravity-local/src/server/test.test.ts for resolveAntigravityExtraArgs, legacy args fallback during testEnvironment, and the probe timeout hint.

Verification

  • pnpm --filter @paperclipai/adapter-antigravity-local build (passed)
  • npx vitest run packages/adapters/antigravity-local server/src/__tests__/antigravity-local-adapter-environment.test.ts server/src/__tests__/antigravity-models.test.ts (6 files, 38 tests passed)
  • pnpm -r typecheck (passed, exit 0)
  • node scripts/check-run-status-write-chokepoint.mjs & bash scripts/check-dockerfile-deps-stage.sh (passed)

@insightflo
insightflo force-pushed the refactor/antigravity-local-extra-args-helper branch from ee2d453 to c2b16af Compare November 18, 2026 07:35
@insightflo
insightflo force-pushed the refactor/antigravity-local-extra-args-helper branch from c2b16af to 539d980 Compare November 18, 2026 07:38
@insightflo
insightflo merged commit 1c2c207 into main Nov 18, 2026
6 checks passed
@insightflo
insightflo deleted the refactor/antigravity-local-extra-args-helper branch November 18, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant