Skip to content

[BUGFIX] Skip native validation for checkbox groups #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Patta wants to merge 1 commit into
base: typo3-v13
Choose a base branch
from
Open

[BUGFIX] Skip native validation for checkbox groups #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Resources/Public/JavaScript/PowermailCondition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,15 @@ class PowermailCondition {
* Note: reportValidity() alone is not sufficient because it always returns
* true when the form has a "novalidate" attribute (i.e. when native
* validation is disabled via TypoScript validation.native = 0).
*
* Native validation is skipped for required powermail checkbox groups because
* its behaviour does not match powermail's checkbox group validation.
*/
#hasValidationErrors() {
if (!this.#form.reportValidity()) {
return true;
if (!this.#hasRequiredCheckboxGroup()) {
if (!this.#form.reportValidity()) {
return true;
}
}
if (this.#form.classList.contains('powermail_form_error')) {
return true;
Expand Down Expand Up @@ -283,6 +288,10 @@ class PowermailCondition {
return this.#form.getAttribute('data-validate') === 'html5';
};

#hasRequiredCheckboxGroup() {
return this.#form.querySelector('input[type="checkbox"][required][data-powermail-multiple="checkbox"]') !== null;
};

#getWrappingContainerByMarkerName(fieldMarker) {
let wrappingContainer = this.#getFieldwrappingContainerByMarker(fieldMarker);
if (wrappingContainer !== null) {
Expand Down
Loading