Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression introduced in 13.1.2 prevents form submission when a required powermail checkbox group is present and the first checkbox is not selected.
The race-condition fix in c21df00 added a native validation check via reportValidity().
While powermail validates checkbox groups as a single logical field, native browser validation evaluates the required checkbox differently, which can cause valid submissions to be rejected.
Skip the native validation check when a required powermail checkbox group is present and continue to rely on powermail's existing validation for this case.
This keeps the race-condition fix in place while restoring the behaviour that worked prior to 13.1.2.
resolves #123