Skip to content

fix: classify global optima in plots using eq_atol - #57

Merged
WojtAcht merged 1 commit into
mainfrom
fix/viz-global-tolerance
Oct 15, 2026
Merged

WojtAcht merged 1 commit into
mainfrom
fix/viz-global-tolerance

Conversation

@WojtAcht

Copy link
Copy Markdown
Member

No description provided.

Plot colors compared fitness to the best value exactly, while the network
metrics use eq_atol. A sink within eq_atol of the best fitness counted
towards n_global_funnels but was drawn as a local sink, and
CMLON.get_local_sinks() returned it together with get_global_sinks().

Colors now use the network's tolerance, and get_local_sinks() returns the
sinks that are not global sinks.
Copilot AI balanced review requested due to automatic review settings October 15, 2026 08:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@WojtAcht
WojtAcht merged commit d155626 into main Oct 15, 2026
3 checks passed
@WojtAcht
WojtAcht deleted the fix/viz-global-tolerance branch October 15, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants