Skip to content

Roll out grid based interactive layout #16974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frederickobrien merged 2 commits into from
Oct 21, 2026
Merged

Roll out grid based interactive layout #16974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75f0cfb
Roll out grid based interactive layout
frederickobrien Oct 20, 2026
70d4a8a
Merge branch 'main' into roll-out-interactive-grid-layout
frederickobrien Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions dotcom-rendering/src/layouts/DecideLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,6 @@ const isInRevampedImmersiveLayoutTest = (article: Article): boolean =>
'articles-and-publishing-revamped-immersive-layout'
] === 'enable';

/**
* Guards grid-based interactive layout behind a 0% a/b test
*/
export const INTERACTIVE_LAYOUT_AB_TEST =
'articles-and-publishing-migrate-interactive-layout';
const isInInteractiveLayoutTest = (article: Article): boolean =>
article.frontendData.config.serverSideABTests[
INTERACTIVE_LAYOUT_AB_TEST
] === 'enable';

const DecideLayoutApps = ({ article, renderingTarget }: AppProps) => {
const format = {
design: article.design,
Expand Down Expand Up @@ -188,9 +178,6 @@ const DecideLayoutApps = ({ article, renderingTarget }: AppProps) => {
format={format}
renderingTarget={renderingTarget}
serverTime={serverTime}
isInInteractiveLayoutTest={isInInteractiveLayoutTest(
article,
)}
/>
);
}
Expand Down Expand Up @@ -352,9 +339,6 @@ const DecideLayoutWeb = ({ article, NAV, renderingTarget }: WebProps) => {
format={format}
renderingTarget={renderingTarget}
serverTime={serverTime}
isInInteractiveLayoutTest={isInInteractiveLayoutTest(
article,
)}
/>
);
}
Expand Down
3 changes: 1 addition & 2 deletions dotcom-rendering/src/layouts/StandardLayout.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const webInteractiveArticle = enhanceArticleType(
{
...StandardFixture,
contentType: 'Interactive',
firstPublicationDate: '2026-10-01T09:00:00.000Z',
firstPublicationDate: '2026-10-30T09:00:00.000Z',
format: {
...StandardFixture.format,
design: 'InteractiveDesign',
Expand All @@ -128,7 +128,6 @@ export const WebInteractive: Story = {
display: webInteractiveArticle.display,
theme: webInteractiveArticle.theme,
},
isInInteractiveLayoutTest: true,
},
parameters: {
formats: [
Expand Down
16 changes: 3 additions & 13 deletions dotcom-rendering/src/layouts/StandardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ interface Props {
format: ArticleFormat;
renderingTarget: RenderingTarget;
serverTime?: number;
isInInteractiveLayoutTest?: boolean;
}

interface WebProps extends Props {
Expand All @@ -57,13 +56,7 @@ interface AppProps extends Props {
}

export const StandardLayout = (props: WebProps | AppProps) => {
const {
article,
format,
renderingTarget,
serverTime,
isInInteractiveLayoutTest,
} = props;
const { article, format, renderingTarget, serverTime } = props;
const {
config: { isPaidContent, host, hasSurveyAd },
editionId,
Expand Down Expand Up @@ -94,8 +87,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {
const isCricketMatchReport =
format.design === ArticleDesign.MatchReport && !!cricketMatchHeaderUrl;

const mtID = '/p/x5ng2y';
const interactiveLayoutSwitchoverDate = new Date('2026-10-01T00:00:00Z');
const interactiveLayoutSwitchoverDate = new Date('2026-10-21T00:00:00Z');
const firstPublicationDate = new Date(
article.firstPublicationDate ?? article.webPublicationDate,
);
Expand Down Expand Up @@ -211,9 +203,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {

{/* This element is used to replace the article with the scorecard when the scorecard tab is clicked */}
<div id="article">
{(isLegacyInteractive ||
(isInteractive && !isInInteractiveLayoutTest)) &&
article.config.shortUrlId !== mtID ? (
{isLegacyInteractive ? (
<InteractiveArticleGridDeprecated {...props} />
) : (
<StandardLayoutArticleGrid
Expand Down
Loading