Skip to content

Roll back full width body experiment for interactive grid - #16973

Merged
frederickobrien merged 2 commits into
mainfrom
roll-back-full-width-interactive-grid-body
Oct 20, 2026
Merged

frederickobrien merged 2 commits into
mainfrom
roll-back-full-width-interactive-grid-body

Conversation

@frederickobrien

Copy link
Copy Markdown
Contributor

This adjusts the interactive grid layout to align with the standard layout, removing the full-width body grid area. Although the approach allowed for a nice one-line configuration for fullWidth atoms, it didn't play nicely with wrapping of content elements:

image

This felt like reason enough to roll back the idea, with the upside being standard and interactive articles can now share the same grid configuration. We can always revisit the idea later.

@frederickobrien frederickobrien self-assigned this Oct 20, 2026
@frederickobrien frederickobrien added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 20, 2026
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@frederickobrien frederickobrien added this to the Interactives milestone Oct 20, 2026
@joshuaguardian
joshuaguardian changed the base branch from main to remove-figure-wrapper-from-interactives October 20, 2026 10:15

@joshuaguardian joshuaguardian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:d1e8d5dee7e07e764d295c8a76c766b36debccc1ae9677a4b592519b39df991e

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d1e8d5dee7e07e764d295c8a76c766b36debccc1ae9677a4b592519b39df991e"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-roll-back-full-width-interactive-grid-body"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32638"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Base automatically changed from remove-figure-wrapper-from-interactives to main October 20, 2026 10:42
@frederickobrien
frederickobrien force-pushed the roll-back-full-width-interactive-grid-body branch from 01edeed to 2edc71c Compare October 20, 2026 10:51
@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Oct 20, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Oct 20, 2026
@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Oct 20, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Oct 20, 2026
@frederickobrien
frederickobrien added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 67c97e5 Oct 20, 2026
30 checks passed
@frederickobrien
frederickobrien deleted the roll-back-full-width-interactive-grid-body branch October 20, 2026 11:40
@gu-prout

gu-prout Bot commented Oct 20, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @frederickobrien 7 minutes and 57 seconds ago) Please check your changes!

@frederickobrien frederickobrien changed the title Roll back full width experiment for interactive grid Roll back full width body experiment for interactive grid Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants