Repository navigation
Roll back full width body experiment for interactive grid - #16973
Merged
frederickobrien merged 2 commits intoOct 20, 2026
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
joshuaguardian
changed the base branch from
main
to
remove-figure-wrapper-from-interactives
October 20, 2026 10:15
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d1e8d5dee7e07e764d295c8a76c766b36debccc1ae9677a4b592519b39df991e"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-roll-back-full-width-interactive-grid-body"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32638"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
Base automatically changed from
remove-figure-wrapper-from-interactives
to
main
October 20, 2026 10:42
frederickobrien
force-pushed
the
roll-back-full-width-interactive-grid-body
branch
from
October 20, 2026 10:51
01edeed to
2edc71c
Compare
frederickobrien
deleted the
roll-back-full-width-interactive-grid-body
branch
October 20, 2026 11:40
|
Seen on PROD (merged by @frederickobrien 7 minutes and 57 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the interactive grid layout to align with the standard layout, removing the full-width body grid area. Although the approach allowed for a nice one-line configuration for fullWidth atoms, it didn't play nicely with wrapping of content elements:
This felt like reason enough to roll back the idea, with the upside being standard and interactive articles can now share the same grid configuration. We can always revisit the idea later.