Repository navigation
feat(regressed): Add produce=false mode - #745
Merged
Merged
Conversation
nsdeschenes
approved these changes
Oct 22, 2026
mjq
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 22, 2026
…128522) To assist with [the project to standardize Kafka access on Arroyo](https://linear.app/getsentry/project/all-services-use-arroyo-for-kafka-communication-04f99f624378/overview), we'd like to move the production of Kafka occurrences out of Vroom and into Sentry. (There is no version of Arroyo for Go, and building it just for this use case would be excessive.) In getsentry/vroom#745, we add a new `produce` query string parameter to the `/regressed` endpoint that controls whether Vroom produces regression occurrences to Kafka (current behaviour) or returns them in the response body (new behaviour). This PR adds a new feature flag that, when enabled, makes Sentry call Vroom with `produce=false` and produce the returned occurrences to Kafka itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To assist with the project to standardize Kafka access on Arroyo, we'd like to move the production of Kafka occurrences out of Vroom and into Sentry. (There is no version of Arroyo for Go, and building it just for this use case would be excessive.)
Vroom currently produces occurrences for detected function regressions in the
POST /regressedendpoint. Add a newproducequery string parameter to it. Whenproduceisfalse, do not produce occurrences to Kafka - instead, return them as part of the response payload.With this in place, Sentry can be updated to call Vroom's
/regressedendpoint withproduce=false, read the returned occurrence payloads, and produce them to Kafka itself. Once that's fully in place, the parameter (and all Kafka-related code) can be removed from Vroom.