Skip to content

feat(profiling): Conditionally emit regression occurrences to Kafka - #128522

Merged
mjq merged 1 commit into
masterfrom
mjq/vroom-regressed-create-occurrences
Oct 22, 2026
Merged

mjq merged 1 commit into
masterfrom
mjq/vroom-regressed-create-occurrences

Conversation

@mjq

@mjq mjq commented Oct 22, 2026

Copy link
Copy Markdown
Member

To assist with the project to standardize Kafka access on Arroyo, we'd like to move the production of Kafka occurrences out of Vroom and into Sentry. (There is no version of Arroyo for Go, and building it just for this use case would be excessive.)

In getsentry/vroom#745, we add a new produce query string parameter to the /regressed endpoint that controls whether Vroom produces regression occurrences to Kafka (current behaviour) or returns them in the response body (new behaviour).

This PR adds a new feature flag that, when enabled, makes Sentry call Vroom with produce=false and produce the returned occurrences to Kafka itself.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 22, 2026
@mjq mjq changed the title feat(profiling): Conditionally emit regression occurrences instead of Vroom feat(profiling): Conditionally emit regression occurrences to Kafka Oct 22, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 6fb7322. Configure here.

@mjq
mjq marked this pull request as ready for review October 22, 2026 15:28
@mjq
mjq requested review from a team as code owners October 22, 2026 15:28
@mjq
mjq merged commit 4e28be2 into master Oct 22, 2026
92 checks passed
@mjq
mjq deleted the mjq/vroom-regressed-create-occurrences branch October 22, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants