Skip to content

ref(image): Use the plain vroom image tags and drop -distroless #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oioki merged 2 commits into from
Oct 19, 2026
Merged

ref(image): Use the plain vroom image tags and drop -distroless #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb73586
ref(deploy): Use the plain vroom image tags
oioki Oct 19, 2026
d52e55e
ci(image): Stop publishing the -distroless image tags
oioki Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ jobs:
docker tag vroom:arm64 ghcr.io/getsentry/vroom:${{ github.sha }}-arm64
docker push ghcr.io/getsentry/vroom:${{ github.sha }}-arm64

# The image is distroless. The "-distroless" tags are kept until
# everything that pulls them (deploys, devservices) moves to the plain tags.
for tag in ${{ github.sha }} ${{ github.sha }}-distroless nightly nightly-distroless; do
for tag in ${{ github.sha }} nightly; do
docker manifest create \
ghcr.io/getsentry/vroom:${tag} \
--amend ghcr.io/getsentry/vroom:${{ github.sha }}-amd64 \
Expand Down Expand Up @@ -162,7 +160,6 @@ jobs:
tag_nightly: false
tag_latest: true
google_ar_image_name: us-central1-docker.pkg.dev/sentryio/vroom/vroom
tags: us-central1-docker.pkg.dev/sentryio/vroom/vroom:${{ github.sha }}-distroless
google_workload_identity_provider: projects/868781662168/locations/global/workloadIdentityPools/prod-github/providers/github-oidc-pool
google_service_account: [email protected]
# The builder stage starts with `COPY . .`, so nothing from a previous
Expand All @@ -182,7 +179,6 @@ jobs:
tag_nightly: false
tag_latest: true
google_ar_image_name: us-docker.pkg.dev/sentryio/vroom-mr/vroom
tags: us-docker.pkg.dev/sentryio/vroom-mr/vroom:${{ github.sha }}-distroless
google_workload_identity_provider: projects/868781662168/locations/global/workloadIdentityPools/prod-github/providers/github-oidc-pool
google_service_account: [email protected]
cache_from: type=local,src=${{ runner.temp }}/vroom-buildcache
Expand Down
2 changes: 1 addition & 1 deletion devservices/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ x-sentry-service-config:
default: [kafka, vroom]
services:
vroom:
image: ghcr.io/getsentry/vroom:nightly-distroless
image: ghcr.io/getsentry/vroom:nightly
ports:
- 127.0.0.1:8085:8085
environment:
Expand Down
2 changes: 1 addition & 1 deletion gocd/templates/bash/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ eval $(regions-project-env-vars --region="${SENTRY_REGION}")
/devinfra/scripts/get-cluster-credentials
k8s-deploy \
--label-selector="${LABEL_SELECTOR}" \
--image="us-central1-docker.pkg.dev/sentryio/vroom/vroom:${GO_REVISION_VROOM_REPO}-distroless" \
--image="us-central1-docker.pkg.dev/sentryio/vroom/vroom:${GO_REVISION_VROOM_REPO}" \
--container-name="vroom"
Loading