Repository navigation
build(docker): Make the distroless image the only vroom image - #734
Merged
Merged
Conversation
Every region now runs the -distroless tag, so drop the Debian stage and build one image. It is published under both the plain SHA/nightly tags and the -distroless tags, so the deploys and devservices that pull -distroless keep working until they move to the plain tags. Co-Authored-By: Claude <[email protected]>
…s-default # Conflicts: # .github/workflows/image.yaml
oioki
marked this pull request as ready for review
October 19, 2026 09:34
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7496acb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
To be merged next week, after production has run on the distroless image for the rest of this week.
Drop the Debian stage and build only the distroless image. It is published under both the plain tags (
<sha>,nightly,latest) and the-distrolesstags (<sha>-distroless,nightly-distroless), pointing at the same image.All SaaS regions run
-distrolesssince #727, and devservices pullsnightly-distroless(#719). Publishing both tags lets them move to the plain tags in a follow-up without a flag day, after which the-distrolesstags can be dropped.This also makes the DockerHub
getsentry/vroomimages (used by self-hosted) distroless. Self-hosted no longer needs a shell in vroom (getsentry/self-hosted#4534, #4552), the-distrolessself-hosted e2e has been passing since #715, and it ran on our self-hosted dogfood instance with profiling working.The image is the same one deployed today, so the GoCD deploy needs no change. The default port is unchanged (8085); only the
EXPOSEmetadata of the old Debian stage said 8080.Fixes SEC-1098