Skip to content

test(cli): Add regression tests for space-separated issue arguments (CLI-1G1) #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

test(cli): Add regression tests for space-separated issue arguments (CLI-1G1) #2084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/cli/test/lib/issue-arguments.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,20 @@ describe("parseIssueArgument", () => {
expect(parseIssueArgument(arg)).toEqual({ text: arg, parsed });
});

// CLI-1G1: agents pass a short ID and numeric ID (or several IDs) as one
// argument. That is a search, never "Invalid issue identifier: contains a
// space".
test.each([
["CLI-1G1 7441717161", "CLI-1G1 7441717161"],
["IOS-HK IOS-R3", "IOS-HK IOS-R3"],
[" login timeout ", "login timeout"],
])("searches for text with spaces: %j (CLI-1G1)", (arg, query) => {
expect(parseIssueArgument(arg)).toEqual({
text: arg,
parsed: { type: "search", query },
});
});

test("keeps the argument as typed and parses its first line", () => {
expect(parseIssueArgument("\n CLI-G \nCLI-H\n")).toEqual({
text: "\n CLI-G \nCLI-H\n",
Expand Down Expand Up @@ -159,6 +173,17 @@ describe("parseIssueArguments", () => {
]);
});

test("splits a short ID and numeric ID passed as one argument (CLI-1G1)", () => {
expect(
parseIssueArguments(["CLI-1G1 7441717161"], { usageHint }).map(
({ parsed }) => parsed,
),
).toEqual([
{ type: "project-search", projectSlug: "cli", suffix: "1G1" },
{ type: "numeric", id: "7441717161" },
]);
});

test("keeps repeated issues: the command decides", () => {
expect(texts(["IOS-1", "IOS-1"])).toEqual(["IOS-1", "IOS-1"]);
});
Expand Down
Loading