Repository navigation
test(cli): Add regression tests for space-separated issue arguments (CLI-1G1) - #2084
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue arguments that contain whitespace (such as agent input combining a short ID and a numeric ID, multiple IDs passed as one argument, or search queries) previously threw
ValidationError: Invalid issue identifier: contains a space.viavalidateResourceId.The parsing changes in PRs #1729, #1730, and #1747 (shipped in 0.48.0) addressed the underlying behavior by routing whitespace-containing inputs to issue search in single-issue parsers and splitting them on whitespace in multi-issue parsers.
This change adds regression tests in
packages/cli/test/lib/issue-arguments.test.tsto ensure these cases (parseIssueArgumentfor searches like"CLI-1G1 7441717161"andparseIssueArgumentssplitting space-separated IDs) remain covered.Fixes CLI-1G1
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.