Repository navigation
ref(cli): Bump @sentry/api to 1.46.0 and move unblocked call sites - #2078
Merged
Merged
Conversation
@sentry/api 1.46.0 carries getsentry/sentry#130348, #130349 and #130350, so these calls now match their generated operations: - issue status update: updateOrganizationIssue - issue merge: updateOrganizationIssues with numeric ids and merge: true - dashboard widget and explore time series: listOrganizationEventsTimeseries - agent conversations list with sort: listOrganizationAiConversations - trace detail with timestamp: getOrganizationTrace Responses are still checked with the CLI's own schemas where they were before. The regenerated issue skill reference picks up new field docs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 7, 2026
BYK
enabled auto-merge (squash)
November 7, 2026 02:30
7 tasks done
BYK
added a commit
that referenced
this pull request
Nov 7, 2026
`main` fails `Repository quality`, `sentry` and `test` on three oxlint
errors ("Unexpected `await` of a non-Promise value"):
- `packages/cli/src/lib/api/explore.ts:105`
- `packages/cli/src/lib/api/issues.ts:625` and `:672`
#1979 made `getOrgSdkConfig()` synchronous and argument-free. #2078,
which merged just before it, added these three call sites in the old
`await getOrgSdkConfig(orgSlug)` form. Each PR passed on its own. This
changes them to `getOrgSdkConfig()`, like the other call sites.
The org slug those calls passed was already unused. #1979 routes
org-scoped requests through `resolveBaseUrl`, which reads the org from
the request path.
<!-- junior-request-attribution:start -->
via @BYK.
<!-- junior-request-attribution:end -->
<!-- junior-session-footer:start -->
<!-- junior-conversation-id:local%3Aweb%3A87622ce3671938950bc6e630 -->
--
[View Session in
Sentry](https://sentry.sentry.io/explore/conversations/local%3Aweb%3A87622ce3671938950bc6e630/?project=4510944073809921)
<!-- junior-session-footer:end -->
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: BYK <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step after #2073 and #2075, which moved the CLI onto the generated
@sentry/apioperations.@sentry/api1.46.0 includes the API docs fixes from getsentry/sentry#130348, #130349 and #130350, so six more call sites now match their generated operation. This PR bumps the package and moves them.Moved onto generated operations
issue resolve/unresolve/archive,feedback resolve/spam/…(org-scoped)updateIssueStatusupdateOrganizationIssueissue mergemergeIssuesupdateOrganizationIssueswith numericids and{merge: true}dashboard viewchart widgetsqueryWidgetTimeserieslistOrganizationEventsTimeseriesyAxisarray,intervalint or duration)exploretime seriesqueryEventsTimeSerieslistOrganizationEventsTimeseriesagent-conversation listlistConversationslistOrganizationAiConversationswithsorttrace view,span view,log viewgetDetailedTracegetOrganizationTracewithtimestampTrace meta already used
getOrganizationTraceMetaand doesn't sendtimestamp, so nothing changes there.Behavior notes
EventsTimeseriesResponseSchemafor widgets andConversationListItemSchemafor conversations. The explore time series and trace detail responses were not validated before and still aren't.issue mergestill turns a 204 (no matching issues) into the same friendly error, and still clears each affected issue's cross-origin cache.agent-conversation list --sortis now typed with the endpoint's sort enum. The command's sort values are a subset of it.Failed to update issue: 403 Forbidden. Status codes and the 401/403 enrichment are unchanged.uniqueValues/key/namedescriptions in the generatedissueskill reference, which is committed here. Typecheck is otherwise unaffected.Remaining
apiRequest*call sites and raw fetchesDetails for each are in getsentry/sentry#130351.
Not in the public schema (needs a getsentry/sentry API docs decision):
organizations.ts:66,projects.ts:576/591: region lookupsusers.ts:21: current usertrials.ts:30/70: trials list/startorg-auth-tokens.ts:77: delete org auth tokendashboards.ts:201/235: dashboard revisions/restoreissues.ts:329: unscopedGET /issues/{id}/issues.ts:632: legacy unscopedPUT /issues/{id}/logs.ts:486: logs querytraces.ts:225: trace-items detail (experimental)releases.ts:425: release set-commitspreprod-artifacts.ts:283/449: build/snapshot uploadgetSharedIssue(issues.ts) andopenSnapshotArchive(preprod-artifacts.ts)Dynamic request identity / transport:
auth.ts:17org-auth-tokens.ts:37/59preprod-artifacts.ts:508/526: snapshot downloadsKept on purpose:
replays.ts:201:replay listkeeps requestinginfo_ids/warning_idsbecause--jsonprints them (see fix(cli): Send the API params the endpoints accept #2075).The Oxlint rule that bans the helpers comes last, after these are resolved.
Verification
pnpm install --frozen-lockfilepasses with the committed lockfile.pnpm run tscandpnpm run lintpass.main(completions×2,upgradeacquireLock,db/resilientreadonly,dsn/code-scanner).listOrganizationEventsTimeseries. I added an org-scopedupdateIssueStatustest. The conversation, explore and trace tests run at the fetch layer and pass unchanged.via @BYK.
--
View Session [Sentry]