Repository navigation
fix(cli): Drop await from three getOrgSdkConfig calls - #2081
Merged
Merged
Conversation
#1979 made getOrgSdkConfig() synchronous and argument-free, and #2078, which merged just before it, added three call sites with the old await getOrgSdkConfig(orgSlug) form. oxlint fails main on the await of a non-Promise value. Use getOrgSdkConfig() like the other call sites. Co-Authored-By: BYK <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfailsRepository quality,sentryandteston three oxlint errors ("Unexpectedawaitof a non-Promise value"):packages/cli/src/lib/api/explore.ts:105packages/cli/src/lib/api/issues.ts:625and:672#1979 made
getOrgSdkConfig()synchronous and argument-free. #2078, which merged just before it, added these three call sites in the oldawait getOrgSdkConfig(orgSlug)form. Each PR passed on its own. This changes them togetOrgSdkConfig(), like the other call sites.The org slug those calls passed was already unused. #1979 routes org-scoped requests through
resolveBaseUrl, which reads the org from the request path.via @BYK.
--
View Session in Sentry