Skip to content

feat(deletes): Skip max_rows_to_delete when lightweight updates are on #8573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dezzeddi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(deletes): Skip max_rows_to_delete when lightweight updates are on #8573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7e8069
feat(deletes): Skip max_rows_to_delete when lightweight updates are on
dezzeddi Oct 20, 2026
107df09
Merge branch 'master' into daniezzeddine/eap-353-remove-the-limits-of…
dezzeddi Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion snuba/web/delete_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,11 @@ def get_new_from_clause() -> Table:
if rows_to_delete == 0:
raise NoRowsToDeleteException
max_rows_allowed = get_storage(storage_key).get_deletion_settings().max_rows_to_delete
if get_option("enforce_max_rows_to_delete", True) and rows_to_delete > max_rows_allowed:
if (
get_option("enforce_max_rows_to_delete", True)
and not get_option("lightweight_delete_mode", "")
and rows_to_delete > max_rows_allowed
):
Comment thread
dezzeddi marked this conversation as resolved.
Resolved
metrics.increment(
"max_rows_exceeded",
tags={"storage": storage_key.value},
Expand Down
Loading