Repository navigation
Conversation
Lightweight updates don't share the per-row cost profile of lightweight deletes, so the max_rows_to_delete guardrail isn't needed when lightweight_delete_mode is set. The row count is still computed since the deletes consumer batches by it. Fixes EAP-353
…-rows-for-deletes
dezzeddi
marked this pull request as ready for review
October 21, 2026 17:12
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 107df09. Configure here.
Member
|
@dezzeddi I think we could probably just update |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lightweight updates don't share the per-row cost profile of lightweight deletes, so the
max_rows_to_deleteguardrail isn't needed whenlightweight_delete_modeis set.Fixes EAP-353