Skip to content

fix(github): Act on feedback in pull request approvals #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcramer merged 1 commit into from
Nov 3, 2026
Merged

fix(github): Act on feedback in pull request approvals #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/junior-github/src/events/pull-request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ export type GitHubPullRequestEvent =
const GITHUB_PULL_REQUEST_EVENT_GUIDANCE: Partial<
Record<GitHubPullRequestEvent, string>
> = {
"pull_request.checks.failed":
"Fix only failures that the pull request causes. Do not skip, disable, or weaken a check to make it pass.",
// An approval with a body also arrives as review.commented in the same
// Turn, so this guidance must not tell the agent to hold off on that body.
"pull_request.review.approved":
"When the approval includes actionable feedback, address it like any other review feedback.",
"pull_request.comment.created":
'After acting on actionable feedback, call github_updatePullRequestFeedback with the exact repo, commentId, and commentKind from Verified details, and status "addressed" or "declined".',
"pull_request.review_comment.created":
Expand Down
4 changes: 3 additions & 1 deletion packages/junior-github/tests/github-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,9 @@ describe("github plugin", () => {
expect(events?.events).toMatchObject({
"pull_request.checks.failed": {
reach: { anyOf: ["repo"] },
guidance: "Inspect the failed checks.",
guidance: expect.stringMatching(
/^Fix only failures .* Inspect the failed checks\.$/,
),
},
"pull_request.comment.created": {
guidance: expect.stringContaining(
Expand Down
Loading