Repository navigation
fix(github): Act on feedback in pull request approvals - #2577
Merged
Merged
Conversation
An approval with a body also arrives as review.commented in the same Turn. Add default guidance so the approval tells the agent to address that feedback, and move the check-failure rule that apps repeated into the plugin defaults. Co-Authored-By: David Cramer <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An approval with a body is delivered as both
pull_request.review.approvedandpull_request.review.commentedin one Turn. Nothing in the default guidance told the agent that the approval's body can be actionable, so app guidance such as "do not make further changes" won and the feedback was not addressed.pull_request.review.approved: address actionable feedback in the approval like any other review feedback.pull_request.checks.failed: fix only failures that the pull request causes, and do not skip, disable, or weaken a check. Apps repeated this rule in their own guidance. It applies to every app, so it belongs in the plugin defaults.App guidance still appends after these defaults.
via @dcramer.
--
View Session [Sentry]