Repository navigation
fix(dashboard): Make the user input note clearly add to the answers - #2502
Merged
Merged
Conversation
The free-text input after a form's fields was labeled "Other" with the help text "an answer that is not listed". That reads like it replaces the picked answers. It does not: the note goes with them. Rename it to "Anything else?" and say that it is sent together with the answers. Slack and the dashboard share the same copy through USER_INPUT_NOTE. Each choice field now says "Pick one" or "Pick any", and a form with more than one field shows how many fields have an answer next to Send. The review items side panel uses the default drawer width, so option descriptions wrap less. Co-Authored-By: BYK <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 1, 2026
BYK
approved these changes
Nov 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BYK reported that a multi-field question in the dashboard sent only the text from "Other". The picked answers were lost. He also reported that the question was cut off at the start, and that the two scroll areas were jarring.
What failed (prod, 0.268.0)
I reproduced the old
UserInputRequestCardin Playwright at 900px viewport height. The card shows above the composer. It has a question area capped atmax-h-48and a form area capped atmax-h-96, and each area scrolls on its own. The card is taller than the space it has, so the composer covers the end of the form: the real "Other" input and the form's Send button. The composer's "Message Junior…" box then looks like the optional field at the bottom. A message sent from the composer answers the request by itself, so the card closes and the picked answers are dropped.The form path itself works. With the old card, the picks plus Other sent
Answer to request ask-1:\nAlpha (a): A2\nBeta (b): B1\n…\nOther: my other text. The review item path onmainalso sends{ values, other }.#2491 removed that card on
main. Questions are now review items that show inline in the transcript and in the review items side panel, and each has one scroll area. This PR fixes what remains onmain:USER_INPUT_NOTEinuser-input-request.tsholds this text, so the Slack modal and the dashboard use the same words. The wire format and the model-facingOther:line do not change.aria-live="polite").narrow(440px). It now uses the default width (560px).The review desk e2e now fills the note with a picked choice, and checks that the request body has both
valuesandother.Screenshots
The review items side panel in a mock Conversation at 1440x900. Each shot has one choice picked, one target checked, and a note typed.
main)Follow-ups
via @BYK.
--
View Session in Sentry