Repository navigation
Dashboard reply silently drops unsent review item picks #2507
Description
In a dashboard Conversation, a message sent from the composer closes the open action item as "Replied in thread" (closeReviewItemsAnsweredByReply in packages/junior/src/chat/review-items/actions.ts, from #2491). Choices the person already picked in the item's form are not sent yet. They are lost without a warning.
- The picks are local state in
UserInputForm(packages/junior-dashboard/src/client/components/UserInputForm.tsx). The composer and the server do not know about them. - Reported by BYK. On 0.268.0, the old question card sat under the composer. The composer looked like the optional "Other" input, so a reply sent only that text. The picks were dropped. Reproduced in Playwright at a viewport height of 900px.
- The reply-closes-item rule is a decision in Review desk second pass: one way to ask a person, and every scenario lands on the desk #2488. This issue is only about the picks that are dropped without a warning.
- Related: fix(dashboard): Make the user input note clearly add to the answers #2502.
via @BYK.
--
Activity
fix(dashboard): Make the user input note clearly add to the answers (#…