Skip to content

fix(i18n): polish Japanese tooltips - #1375

Merged
EtienneLescot merged 1 commit into
getopenscreen:mainfrom
nabikita3974:ja-jp-tooltip-review
Oct 24, 2026
Merged

EtienneLescot merged 1 commit into
getopenscreen:mainfrom
nabikita3974:ja-jp-tooltip-review

Conversation

@nabikita3974

@nabikita3974 nabikita3974 commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Native-speaker review of the Japanese (ja-JP) tooltips from #912, #914 and #915.
The machine-translated wording was mostly accurate. I fixed places that read
stiffly or used an unnatural particle or word, for example:

  • autoFocusAllTip: カーソルを追従します → カーソルに追従します (particle)
  • rewindTip: 元に戻ります → 取り消されます (the later changes are discarded, not restored)
  • cpuBackendHint: 低速です → 遅いです (more natural)
  • editClipTip, dragToReorderHint: clip start and end are now worded as
    開始位置 / 終了位置 (previously 開始 / 終了), matching the existing Edit-clip dialog.

Scope: the ja-JP strings changed by #912, #914 and #915, as requested in #913.
13 strings changed in total. Keys and {{placeholders}} are unchanged.

Not changed: editInOutPoints ("イン/アウトポイントを編集") still uses イン/アウト,
while editClipTip, dragToReorderHint and the Edit-clip dialog all say
開始位置/終了位置. It is outside the string set #913 asks to review, so I left it
untouched; happy to align it in this PR or a follow-up if you prefer.

Related issue

Refs #913

This covers the ja-JP part only. It does not close the multilingual review issue.

Type of change

  • Bug fix

Release impact

  • Patch

Desktop impact

  • Not platform-specific

Screenshots / video

Copy-only changes. I did not check the strings in the running app.

Testing

  • npm run i18n:check: passed (all 14 locales match en, 940 literal keys resolve)
  • Full npm run test: 356 files, 4962 tests passed, 6 skipped (Node v24.13.0; the repo pins 22.22.1)

AI assistance: OpenCode (DeepSeek) drafted candidate wording and this description;
Claude and GLM were used for second opinions. I reviewed every
changed ja-JP string myself and made each decision, including a few where I
overrode the AI.

Summary by CodeRabbit

  • Localization
    • Refined Japanese editor guidance for cursor styling and zoom, recording behavior on macOS and Windows, transcription speed, clip editing, and rewinding.
    • Clarified Japanese launch guidance for restarting recordings, mirrored text, and cursor tips.
    • Updated Japanese settings and timeline wording for frame roundness, cursor fade-out, cursor-following zoom, and clip start and end positions.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6d2cc1a7-125f-498d-a560-08da6bba14e0
Commits

Reviewing files that changed from the base of the PR and between 264975d and c71f94e.

Files selected for processing: 4
  • src/i18n/locales/ja-JP/editor.json
  • src/i18n/locales/ja-JP/launch.json
  • src/i18n/locales/ja-JP/settings.json
  • src/i18n/locales/ja-JP/timeline.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

Japanese editor, launch, settings, and timeline translations were revised to clarify interface guidance. The changes do not alter translation keys or application behavior.

Changes: Japanese locale wording

Layer / File(s) Summary
Japanese UI guidance wording
src/i18n/locales/ja-JP/editor.json, src/i18n/locales/ja-JP/launch.json, src/i18n/locales/ja-JP/settings.json, src/i18n/locales/ja-JP/timeline.json
Revised Japanese wording for cursor behavior, recording, clip editing, timeline actions, and other interface guidance.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: Minimal · up to c71f9

The Japanese wording updates are limited to translations and are ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: polishing Japanese tooltip translations.
Description check Passed The description covers the required sections, explains the 13 Japanese translation changes, references issue #913, identifies the patch impact, states the platform scope, and documents testing results…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the required sections, explains the 13 Japanese translation changes, references issue #913, identifies the patch impact, states the platform scope, and documents testing results.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit f63ffb1 into getopenscreen:main Oct 24, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants